Skip to content

Create a new Ubunutu 22.04 (jammy) build for platform010 (take 2)#79945

Closed
mehtanirav wants to merge 1 commit intomasterfrom
nirav_platform010_build_2
Closed

Create a new Ubunutu 22.04 (jammy) build for platform010 (take 2)#79945
mehtanirav wants to merge 1 commit intomasterfrom
nirav_platform010_build_2

Conversation

@mehtanirav
Copy link
Copy Markdown
Contributor

@mehtanirav mehtanirav commented Jun 21, 2022 •
edited
Loading

Motivation

In order to match the internal platform010 builds, we are creating a new config to run on PRs that uses compiler and package versions >= used in platform010. Here are the versions used in the new build

  • Ubuntu 22.04 (Jammy-Jellyfish)
  • Clang-12
  • Python 3.8
  • CUDA 11.6

Summary of Changes

  • As nvidia/docker images only support Cuda 11.7 with Ubuntu 22.04, we are starting with base Ubuntu 22.04 docker images, and then installing Cuda 11.6

  • Fetching install_cuda.sh from pytorch/builder repo in order to install Cuda using wget

  • libssl-dev has been upgraded to libssl3 in Ubuntu 22.04. Instead, we are using include and lib folders downloaded with Openssl1.1.1

  • Clang-12 requires libomp-12-dev to work with OpenMP which is added to the install_base.sh file.

  • Minor fixes to handle compilation errors generated when using clang-12.
    - In pow_test.cpp adding a static_cast to input of sqrt method
    - In vec512_qint.h, explicitly defining copy-assignment operator as its implicit definition is deprecated due to
    user-declared copy-constructor in C++11

@mehtanirav mehtanirav requested review from a team and jeffdaily as code owners June 21, 2022 15:52
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 21, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit bf1f58a (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@mehtanirav mehtanirav requested review from atalman, kit1980 and malfet June 21, 2022 15:53
@kit1980 kit1980 added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Jun 21, 2022
@mehtanirav mehtanirav force-pushed the nirav_platform010_build_2 branch from 83de79e to bf1f58a Compare June 21, 2022 15:56
@mehtanirav mehtanirav requested a review from seemethere June 21, 2022 15:57
@mehtanirav
Copy link
Copy Markdown
Contributor Author

mehtanirav commented Jun 21, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 21, 2022

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 21, 2022

@mehtanirav your PR has been successfully merged.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 21, 2022

Hey @mehtanirav.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 22, 2022
@mehtanirav @facebook-github-bot
Create a new Ubunutu 22.04 (jammy) build for platform010 (take 2) (#7…
041c026 
…9945) (#79945)

Summary:
###  Motivation

In order to match the internal platform010 builds, we are creating a new config to run on PRs that uses compiler and package versions >= used in platform010. Here are the versions used in the new build

- Ubuntu 22.04 (Jammy-Jellyfish)
- Clang-12
- Python 3.8
- CUDA 11.6

### Summary of Changes

- As `nvidia/docker` images only support Cuda 11.7 with Ubuntu 22.04, we are starting with base Ubuntu 22.04 docker images, and then installing Cuda 11.6

- Fetching `install_cuda.sh` from `pytorch/builder` repo in order to install Cuda using `wget`

- `libssl-dev` has been upgraded to libssl3 in Ubuntu 22.04. Instead, we are using `include` and `lib` folders downloaded with `Openssl1.1.1`

- `Clang-12` requires `libomp-12-dev` to work with `OpenMP` which is added to the `install_base.sh` file.

- Minor fixes to handle compilation errors generated when using `clang-12`.
      - In `pow_test.cpp` adding a `static_cast` to input of `sqrt` method
      - In `vec512_qint.h`, explicitly defining `copy-assignment` operator as its implicit definition is deprecated due to
         user-declared `copy-constructor` in C++11

Pull Request resolved: #79945
Approved by: https://github.com/seemethere, https://github.com/kit1980

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/163fc0e7520a20069ef4d56ff783314ef0a667dd

Reviewed By: atalman

Differential Revision: D37327806

Pulled By: mehtanirav

fbshipit-source-id: b86f397c856f8e07f0250ea0e0cfe1b2725d1ec1
miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022
@mehtanirav @miladm
Create a new Ubunutu 22.04 (jammy) build for platform010 (take 2) (py…
f814f8e 
…torch#79945)

###  Motivation

In order to match the internal platform010 builds, we are creating a new config to run on PRs that uses compiler and package versions >= used in platform010. Here are the versions used in the new build

- Ubuntu 22.04 (Jammy-Jellyfish)
- Clang-12
- Python 3.8
- CUDA 11.6

### Summary of Changes

- As `nvidia/docker` images only support Cuda 11.7 with Ubuntu 22.04, we are starting with base Ubuntu 22.04 docker images, and then installing Cuda 11.6

- Fetching `install_cuda.sh` from `pytorch/builder` repo in order to install Cuda using `wget`

- `libssl-dev` has been upgraded to libssl3 in Ubuntu 22.04. Instead, we are using `include` and `lib` folders downloaded with `Openssl1.1.1`

- `Clang-12` requires `libomp-12-dev` to work with `OpenMP` which is added to the `install_base.sh` file.

- Minor fixes to handle compilation errors generated when using `clang-12`.
      - In `pow_test.cpp` adding a `static_cast` to input of `sqrt` method
      - In `vec512_qint.h`, explicitly defining `copy-assignment` operator as its implicit definition is deprecated due to
         user-declared `copy-constructor` in C++11
Pull Request resolved: pytorch#79945
Approved by: https://github.com/seemethere, https://github.com/kit1980
@github-actions github-actions Bot deleted the nirav_platform010_build_2 branch February 17, 2024 01:52
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@mehtanirav @pytorchmergebot
Create a new Ubunutu 22.04 (jammy) build for platform010 (take 2) (py…
60ae6c1 
…torch#79945)

###  Motivation

In order to match the internal platform010 builds, we are creating a new config to run on PRs that uses compiler and package versions >= used in platform010. Here are the versions used in the new build

- Ubuntu 22.04 (Jammy-Jellyfish)
- Clang-12
- Python 3.8
- CUDA 11.6

### Summary of Changes

- As `nvidia/docker` images only support Cuda 11.7 with Ubuntu 22.04, we are starting with base Ubuntu 22.04 docker images, and then installing Cuda 11.6

- Fetching `install_cuda.sh` from `pytorch/builder` repo in order to install Cuda using `wget`

- `libssl-dev` has been upgraded to libssl3 in Ubuntu 22.04. Instead, we are using `include` and `lib` folders downloaded with `Openssl1.1.1`

- `Clang-12` requires `libomp-12-dev` to work with `OpenMP` which is added to the `install_base.sh` file.

- Minor fixes to handle compilation errors generated when using `clang-12`.
      - In `pow_test.cpp` adding a `static_cast` to input of `sqrt` method
      - In `vec512_qint.h`, explicitly defining `copy-assignment` operator as its implicit definition is deprecated due to
         user-declared `copy-constructor` in C++11
Pull Request resolved: pytorch#79945
Approved by: https://github.com/seemethere, https://github.com/kit1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@malfet malfet Awaiting requested review from malfet

@atalman atalman Awaiting requested review from atalman

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mehtanirav @facebook-github-bot @pytorchmergebot @kit1980 @seemethere