Fix //:module_test Conversion_MultiCUDA#79926
Conversation
🔗 Helpful links
✅ No Failures (0 Pending)As of commit c3b0b06 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
soulitzer
left a comment
There was a problem hiding this comment.
Thanks for the fix, test failures look real though
| } | ||
| } | ||
|
|
||
| TEST_F(ModuleTest, Conversion_MultiCUDA_NoGrad) { |
There was a problem hiding this comment.
My guess as to why this test is failing is that you should rename this to Conversion_NoGrad_MultiCUDA (so that it ends with CUDA) or else this test will also be run for non-CUDA builds.
|
@pytorchbot merge -g |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
@vors your PR has been successfully merged. |
|
Hey @vors. |
Summary: Fixes #79871 Make `module.cpp` tests respect change that was made in #78436 (no int types in autograd). Note that there still a gap in Cmake test -- it's unclear why it didn't fail CI before. As far as I can tell it should be executed, because it's included here https://github.com/pytorch/pytorch/blob/79507d2a9d06d4a3fb50eb21b30e08cc044776ce/test/cpp/api/CMakeLists.txt#L17:L17 Pull Request resolved: #79926 Approved by: https://github.com/soulitzer Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/a8b098859688a3f1993821eecc036be973a15605 Reviewed By: atalman Differential Revision: D37333256 Pulled By: atalman fbshipit-source-id: 0b914fbcc5da72fbadf0f3c2f6b6af1a198cf6fb
Fixes pytorch#79871 Make `module.cpp` tests respect change that was made in pytorch#78436 (no int types in autograd). Note that there still a gap in Cmake test -- it's unclear why it didn't fail CI before. As far as I can tell it should be executed, because it's included here https://github.com/pytorch/pytorch/blob/79507d2a9d06d4a3fb50eb21b30e08cc044776ce/test/cpp/api/CMakeLists.txt#L17:L17 Pull Request resolved: pytorch#79926 Approved by: https://github.com/soulitzer
Fixes pytorch#79871 Make `module.cpp` tests respect change that was made in pytorch#78436 (no int types in autograd). Note that there still a gap in Cmake test -- it's unclear why it didn't fail CI before. As far as I can tell it should be executed, because it's included here https://github.com/pytorch/pytorch/blob/e4a7ecafa61d9d9a7ac1f154264d6f5ccffe12bb/test/cpp/api/CMakeLists.txt#L17:L17 Pull Request resolved: pytorch#79926 Approved by: https://github.com/soulitzer
Fixes #79871
Make
module.cpptests respect change that was made in #78436 (no int types in autograd).Note that there still a gap in Cmake test -- it's unclear why it didn't fail CI before.
As far as I can tell it should be executed, because it's included here https://github.com/pytorch/pytorch/blob/79507d2a9d06d4a3fb50eb21b30e08cc044776ce/test/cpp/api/CMakeLists.txt#L17:L17