Reland #2 of "Added {logical_not, trace} refs, moved logical ops to use method overloads" by Chillee · Pull Request #79819 · pytorch/pytorch

Chillee · 2022-06-17T22:41:00Z

Stack from ghstack (oldest at bottom):

-> Reland #2 of "Added {logical_not, trace} refs, moved logical ops to use method overloads" #79819

…se method overloads" [ghstack-poisoned]

facebook-github-bot · 2022-06-17T22:41:07Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/79819
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit a0b732f (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

…al ops to use method overloads"" [ghstack-poisoned]

…se method overloads" ghstack-source-id: 6d14a53 Pull Request resolved: #79819

mruberry

Stamped!

…al ops to use method overloads"" [ghstack-poisoned]

…se method overloads" ghstack-source-id: 0ecd949 Pull Request resolved: #79819

Chillee · 2022-06-20T18:43:39Z

@pytorchbot help

pytorch-bot · 2022-06-20T18:43:40Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'help' (choose from 'merge', 'revert', 'rebase')

usage: @pytorchbot [-h] {merge,revert,rebase} ...

Try @pytorchbot --help for more info.

Chillee · 2022-06-20T18:43:55Z

@pytorchbot --help

pytorch-bot · 2022-06-20T18:43:56Z

PyTorchBot Help

usage: @pytorchbot [-h] {merge,revert,rebase} ...

In order to invoke the bot on your PR, include a line that starts with
@pytorchbot anywhere in a comment. That line will form the command; no
multi-line commands are allowed. 

Example:
    Some extra context, blah blah, wow this PR looks awesome

    @pytorchbot merge

optional arguments:
  -h, --help            Show this help message and exit.

command:
  {merge,revert,rebase}
    merge               Merge a PR
    revert              Revert a PR
    rebase              Rebase a PR

Merge

usage: @pytorchbot merge [-g | -f | -l]

Merge an accepted PR, subject to the rules in .github/merge_rules.json.
By default, this will wait for all required checks to succeed before merging.

optional arguments:
  -g, --green        Merge when *all* status checks pass.
  -f, --force        Merge without checking anything. ONLY USE THIS FOR CRITICAL FAILURES.
  -l, --land-checks  Merge with land time checks. (EXPERIMENTAL! DO NOT USE)

Revert

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Revert a merged PR. This requires that you are a Meta employee.

Example:
  @pytorchbot revert -m="This is breaking tests on trunk. hud.pytorch.org/" -c=nosignal

optional arguments:
  -m MESSAGE, --message MESSAGE
                        The reason you are reverting, will be put in the commit message. Must be longer than 3 words.
  -c {nosignal,ignoredsignal,landrace,weird,ghfirst}, --classification {nosignal,ignoredsignal,landrace,weird,ghfirst}
                        A machine-friendly classification of the revert reason.

Rebase

usage: @pytorchbot rebase [-s | -b BRANCH]

Rebase a PR. Rebasing defaults to the default branch of pytorch (master).
You, along with any member of the pytorch organization, can rebase your PR.

optional arguments:
  -s, --stable          Rebase to viable/strict
  -b BRANCH, --branch BRANCH
                        Branch you would like to rebase to

Chillee · 2022-06-20T18:44:12Z

@pytorchbot merge -g

pytorchmergebot · 2022-06-20T18:45:27Z

@pytorchbot successfully started a merge job. Check the current status here

github-actions · 2022-06-20T19:51:18Z

Hey @Chillee.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Chillee · 2022-06-20T20:54:43Z

@pytorchbot revert -m="land raced with softshrink refs" -c=landrace

malfet · 2022-06-20T20:57:39Z

@pytorchbot revert -m "land race with softshring refs" -c landrace

malfet · 2022-06-20T20:57:59Z

@pytorchbot help

malfet · 2022-06-20T21:22:09Z

@pytorchbot successfully started a revert job. Check the current status here

…ops to use method overloads"" This reverts commit f3665dd. Reverted #79819 on behalf of https://github.com/malfet due to land raced with softshrink refs

pytorchmergebot · 2022-06-20T21:55:53Z

@pytorchbot successfully started a revert job. Check the current status here

pytorch-bot · 2022-06-20T21:55:55Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'help' (choose from 'merge', 'revert', 'rebase')

usage: @pytorchbot [-h] {merge,revert,rebase} ...

Try @pytorchbot --help for more info.

pytorchmergebot · 2022-06-20T21:55:56Z

Reverting PR 79819 failed due to Command git -C /home/runner/actions-runner/_work/pytorch/pytorch revert --no-edit f3665dd23719137e034b306880c6fd0cec96881d returned non-zero exit code 1

On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

Raised by https://github.com/pytorch/pytorch/actions/runs/2531718031

pytorch-bot · 2022-06-20T22:16:49Z

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

pytorch-bot · 2022-06-20T22:18:35Z

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

pytorchmergebot · 2022-06-20T22:19:02Z

@pytorchbot successfully started a revert job. Check the current status here

pytorchmergebot · 2022-06-20T22:19:06Z

Reverting PR 79819 failed due to Command git -C /home/runner/actions-runner/_work/pytorch/pytorch revert --no-edit f3665dd23719137e034b306880c6fd0cec96881d returned non-zero exit code 1

On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

Raised by https://github.com/pytorch/pytorch/actions/runs/2531806076

pytorch-bot · 2022-06-20T22:19:26Z

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

pytorch-bot · 2022-06-20T22:32:06Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'successfully' (choose from 'merge', 'revert', 'rebase')

usage: @pytorchbot [-h] {merge,revert,rebase} ...

Try @pytorchbot --help for more info.

…ps to use method overloads" Pull Request resolved: pytorch#79819 Approved by: https://github.com/mruberry

…ogical ops to use method overloads"" This reverts commit f3665dd. Reverted pytorch#79819 on behalf of https://github.com/malfet due to land raced with softshrink refs

Reland #2 of "Added {logical_not, trace} refs, moved logical ops to u…

9fdae92

…se method overloads" [ghstack-poisoned]

Chillee requested review from mruberry and ngimel as code owners June 17, 2022 22:41

facebook-github-bot added the cla signed label Jun 17, 2022

Update on "Reland #2 of "Added {logical_not, trace} refs, moved logic…

311ebf8

…al ops to use method overloads"" [ghstack-poisoned]

Chillee added a commit that referenced this pull request Jun 17, 2022

Reland #2 of "Added {logical_not, trace} refs, moved logical ops to u…

a527d34

…se method overloads" ghstack-source-id: 6d14a53 Pull Request resolved: #79819

mruberry approved these changes Jun 17, 2022

View reviewed changes

Update on "Reland #2 of "Added {logical_not, trace} refs, moved logic…

a0b732f

…al ops to use method overloads"" [ghstack-poisoned]

Chillee added a commit that referenced this pull request Jun 20, 2022

Reland #2 of "Added {logical_not, trace} refs, moved logical ops to u…

6468600

…se method overloads" ghstack-source-id: 0ecd949 Pull Request resolved: #79819

pytorchmergebot added the Merged label Jun 20, 2022

pytorchmergebot closed this in f3665dd Jun 20, 2022

malfet added the Reverted label Jun 20, 2022

facebook-github-bot deleted the gh/chillee/63/head branch June 24, 2022 14:17

miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022

Reland pytorch#2 of "Added {logical_not, trace} refs, moved logical o…

cbb182d

…ps to use method overloads" Pull Request resolved: pytorch#79819 Approved by: https://github.com/mruberry

Conversation

Chillee commented Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

Chillee commented Jun 20, 2022

Uh oh!

pytorch-bot bot commented Jun 20, 2022

Uh oh!

Chillee commented Jun 20, 2022

Uh oh!

pytorch-bot bot commented Jun 20, 2022

PyTorchBot Help

Merge

Revert

Rebase

Uh oh!

Chillee commented Jun 20, 2022

Uh oh!

pytorchmergebot commented Jun 20, 2022

Uh oh!

github-actions bot commented Jun 20, 2022

Uh oh!

Chillee commented Jun 20, 2022

Uh oh!

malfet commented Jun 20, 2022

Uh oh!

malfet commented Jun 20, 2022

Uh oh!

malfet commented Jun 20, 2022

Uh oh!

pytorchmergebot commented Jun 20, 2022

Uh oh!

pytorch-bot bot commented Jun 20, 2022

Uh oh!

pytorchmergebot commented Jun 20, 2022

Uh oh!

pytorch-bot bot commented Jun 20, 2022

Uh oh!

pytorch-bot bot commented Jun 20, 2022

Uh oh!

pytorchmergebot commented Jun 20, 2022

Uh oh!

pytorchmergebot commented Jun 20, 2022

Uh oh!

pytorch-bot bot commented Jun 20, 2022

Uh oh!

pytorch-bot bot commented Jun 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Chillee commented Jun 17, 2022 •

edited

Loading

facebook-github-bot commented Jun 17, 2022 •

edited

Loading