[Vulkan] Fix mm op null pointer dereference on Android#79701
Closed
manuelcandales wants to merge 1 commit intopytorch:masterfrom
Closed
[Vulkan] Fix mm op null pointer dereference on Android#79701manuelcandales wants to merge 1 commit intopytorch:masterfrom
manuelcandales wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 296a08b (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37189192 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37189192 |
c12a0ff to
83eb9d3
Compare
Summary: Pull Request resolved: pytorch#79701 The use of `c10::nullopt` instead of `c10::optional<Tensor>()` caused a null pointer dereference on Android. Test Plan: On Mac: ``` buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac ``` On Android: ``` buck build -c ndk.custom_libcxx=false -c pt.enable_qpl=0 //xplat/caffe2:pt_vulkan_api_test_binAndroid\#android-arm64 --show-output adb push buck-out/gen/xplat/caffe2/pt_vulkan_api_test_binAndroid\#android-arm64 /data/local/tmp/vulkan_api_test adb shell "/data/local/tmp/vulkan_api_test" ``` Reviewed By: SS-JIA Differential Revision: D37189192 fbshipit-source-id: a7f264aeefc92cf956b7b75833d2cab6c5a04054
83eb9d3 to
296a08b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37189192 |
SS-JIA
approved these changes
Jun 20, 2022
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Collaborator
|
@manuelcandales your PR has been successfully merged. |
Contributor
|
Hey @manuelcandales. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
Summary: Pull Request resolved: #79701 The use of `c10::nullopt` instead of `c10::optional<Tensor>()` caused a null pointer dereference on Android. Test Plan: On Mac: ``` buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac ``` On Android: ``` buck build -c ndk.custom_libcxx=false -c pt.enable_qpl=0 //xplat/caffe2:pt_vulkan_api_test_binAndroid\#android-arm64 --show-output adb push buck-out/gen/xplat/caffe2/pt_vulkan_api_test_binAndroid\#android-arm64 /data/local/tmp/vulkan_api_test adb shell "/data/local/tmp/vulkan_api_test" ``` Reviewed By: SS-JIA Differential Revision: D37189192 fbshipit-source-id: fc9c917a90358227e9a076d52b3c739d452b4a96
miladm
pushed a commit
to miladm/pytorch
that referenced
this pull request
Jun 27, 2022
Summary: The use of `c10::nullopt` instead of `c10::optional<Tensor>()` caused a null pointer dereference on Android. Test Plan: On Mac: ``` buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac ``` On Android: ``` buck build -c ndk.custom_libcxx=false -c pt.enable_qpl=0 //xplat/caffe2:pt_vulkan_api_test_binAndroid\#android-arm64 --show-output adb push buck-out/gen/xplat/caffe2/pt_vulkan_api_test_binAndroid\#android-arm64 /data/local/tmp/vulkan_api_test adb shell "/data/local/tmp/vulkan_api_test" ``` Reviewed By: SS-JIA Differential Revision: D37189192 Pull Request resolved: pytorch#79701 Approved by: https://github.com/SS-JIA
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: The use of `c10::nullopt` instead of `c10::optional<Tensor>()` caused a null pointer dereference on Android. Test Plan: On Mac: ``` buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac ``` On Android: ``` buck build -c ndk.custom_libcxx=false -c pt.enable_qpl=0 //xplat/caffe2:pt_vulkan_api_test_binAndroid\#android-arm64 --show-output adb push buck-out/gen/xplat/caffe2/pt_vulkan_api_test_binAndroid\#android-arm64 /data/local/tmp/vulkan_api_test adb shell "/data/local/tmp/vulkan_api_test" ``` Reviewed By: SS-JIA Differential Revision: D37189192 Pull Request resolved: pytorch#79701 Approved by: https://github.com/SS-JIA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The use of
c10::nulloptinstead ofc10::optional<Tensor>()caused a null pointer dereference on Android.Test Plan:
On Mac:
On Android:
Reviewed By: SS-JIA
Differential Revision: D37189192