Skip to content

Fix BC Test for SymInt#79612

Closed
zengk95 wants to merge 1 commit intomasterfrom
fix-bc-SymInt
Closed

Fix BC Test for SymInt#79612
zengk95 wants to merge 1 commit intomasterfrom
fix-bc-SymInt

Conversation

@zengk95
Copy link
Copy Markdown
Contributor

@zengk95 zengk95 commented Jun 15, 2022 •
edited
Loading

see title

2022-06-15T15:20:12.5183743Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-06-15T15:20:12.5183765Z 
2022-06-15T15:20:12.5183880Z Broken ops: [
2022-06-15T15:20:12.5184275Z 	aten::empty.SymInt(SymInt[] size, *, int? dtype=None, int? layout=None, Device? device=None, bool? pin_memory=None, int? memory_format=None) -> Tensor
2022-06-15T15:20:12.5184342Z ]
2022-06-15T15:20:12.6303306Z + cleanup
2022-06-15T15:20:12.6303395Z + retcode=1
2022-06-15T15:20:12.6303463Z + set +x
2022-06-15T15:20:12.6345211Z ##[error]Process completed with exit code 1.
2022-06-15T15:20:12.6377724Z Prepare all required actions
2022-06-15T15:20:12.6377844Z Getting action download info

@zengk95 zengk95 requested review from a team and malfet June 15, 2022 15:24
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 15, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 6b9fa37 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

janeyx99
janeyx99 reviewed Jun 15, 2022
View reviewed changes
Comment thread test/forward_backward_compatibility/check_forward_backward_compatibility.py
("aten::_weight_norm_cuda_interface_backward", datetime.date(9999, 1, 1)),
("aten::segment_reduce", datetime.date(9999, 1, 1)),
("aten::_segment_reduce_backward", datetime.date(9999, 1, 1)),
("aten::empty.SymInt", datetime.date(9999, 1, 1)),
Copy link
Copy Markdown
Contributor

@janeyx99 janeyx99 Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
("aten::empty.SymInt", datetime.date(9999, 1, 1)),
("aten::empty.SymInt", datetime.date(2022, 7, 1)),

Should we be setting more reasonable dates here?

Copy link
Copy Markdown
Contributor Author

@zengk95 zengk95 Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when do we set the dates to that versus a normal date?

Copy link
Copy Markdown
Contributor

@malfet malfet Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sets a time-bomb for reverting the revert by Jul 1st, which I don't think anyone promises will happen

@zengk95
Copy link
Copy Markdown
Contributor Author

zengk95 commented Jun 15, 2022

@pytorchbot merge -f

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 15, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 15, 2022

Hey @zengk95.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 20, 2022
@zengk95 @facebook-github-bot
Fix BC Test for SymInt (#79612) (#79612)
66c2701 
Summary:
see title
```
2022-06-15T15:20:12.5183743Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.
2022-06-15T15:20:12.5183765Z
2022-06-15T15:20:12.5183880Z Broken ops: [
2022-06-15T15:20:12.5184275Z 	aten::empty.SymInt(SymInt[] size, *, int? dtype=None, int? layout=None, Device? device=None, bool? pin_memory=None, int? memory_format=None) -> Tensor
2022-06-15T15:20:12.5184342Z ]
2022-06-15T15:20:12.6303306Z + cleanup
2022-06-15T15:20:12.6303395Z + retcode=1
2022-06-15T15:20:12.6303463Z + set +x
2022-06-15T15:20:12.6345211Z ##[error]Process completed with exit code 1.
2022-06-15T15:20:12.6377724Z Prepare all required actions
2022-06-15T15:20:12.6377844Z Getting action download info

```

Pull Request resolved: #79612
Approved by: https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/dcf381e9820df18b807c48c8a0a41acd3f7c09dd

Reviewed By: malfet

Differential Revision: D37208287

Pulled By: zengk95

fbshipit-source-id: 4c24cc69d16713568dc990d597f66972b9b56e47
@zengk95 zengk95 deleted the fix-bc-SymInt branch July 6, 2022 15:58
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@zengk95 @pytorchmergebot
Fix BC Test for SymInt (pytorch#79612)
44d5dc1 
see title
```
2022-06-15T15:20:12.5183743Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.
2022-06-15T15:20:12.5183765Z
2022-06-15T15:20:12.5183880Z Broken ops: [
2022-06-15T15:20:12.5184275Z 	aten::empty.SymInt(SymInt[] size, *, int? dtype=None, int? layout=None, Device? device=None, bool? pin_memory=None, int? memory_format=None) -> Tensor
2022-06-15T15:20:12.5184342Z ]
2022-06-15T15:20:12.6303306Z + cleanup
2022-06-15T15:20:12.6303395Z + retcode=1
2022-06-15T15:20:12.6303463Z + set +x
2022-06-15T15:20:12.6345211Z ##[error]Process completed with exit code 1.
2022-06-15T15:20:12.6377724Z Prepare all required actions
2022-06-15T15:20:12.6377844Z Getting action download info

```
Pull Request resolved: pytorch#79612
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@janeyx99 janeyx99 janeyx99 left review comments

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zengk95 @facebook-github-bot @pytorchmergebot @malfet @janeyx99