Revert "Revert "Python Bindings for SymInts (#78135)""#79608
Closed
ezyang wants to merge 2 commits intogh/ezyang/1222/basefrom
Closed
Revert "Revert "Python Bindings for SymInts (#78135)""#79608ezyang wants to merge 2 commits intogh/ezyang/1222/basefrom
ezyang wants to merge 2 commits intogh/ezyang/1222/basefrom
Conversation
This reverts commit b8db0a0. [ghstack-poisoned]
Contributor
🔗 Helpful links
❌ 17 New FailuresAs of commit 06ebcd9 (more details on the Dr. CI page): Expand to see more
🕵️ 17 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
Contributor
Author
|
Here is the diff from Nick's OG PR: |
This reverts commit b8db0a0. [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Jun 15, 2022
vfdev-5
reviewed
Jun 15, 2022
Comment on lines
+295
to
+305
| def test_fx_trace_intlist(self): | ||
| class CustomModule(torch.nn.Module): | ||
| def forward(self, x): | ||
| bs, c, h, w = x.shape | ||
| return F.pad(x, (0, w % 2, 0, h % 2, 0, 0)) | ||
|
|
||
| m = CustomModule() | ||
| x = torch.rand(1, 3, 4, 4) | ||
| # should not TypeError: pad(): argument 'pad' (position 2) must be | ||
| # tuple of ints, not tuple | ||
| torch.fx.symbolic_trace(m) |
Contributor
There was a problem hiding this comment.
Technically, we do not need to create a custom module to repro the issue, just a function:
def foo(x):
bs, c, h, w = x.shape
return F.pad(x, (0, w % 2, 0, h % 2, 0, 0))
torch.fx.symbolic_trace(foo)
Contributor
There was a problem hiding this comment.
Agreed, or at least remove the unused x variable.
Krovatkin
pushed a commit
to Krovatkin/pytorch
that referenced
this pull request
Jun 15, 2022
This reverts commit b8db0a0. ghstack-source-id: 602ffd6 Pull Request resolved: pytorch#79608
wconstab
pushed a commit
that referenced
this pull request
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This reverts commit b8db0a0.