Added edge case checking in isGreen#79565
Conversation
🔗 Helpful links
✅ No Failures (0 Pending)As of commit d97717c (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@pytorchbot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
|
Successfully rebased |
50ea095 to
6262acc
Compare
|
@pytorchbot merge -f |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @swang392. |
There was a problem hiding this comment.
The move may be to move this back to a local variable under isGreen as this dictionary changes now.
There was a problem hiding this comment.
Once you move the dictionary in here, this should no longer be necessary
There was a problem hiding this comment.
Would be good to print a join of the regexes here for better debugging
6262acc to
bf3ee1c
Compare
…sing workflows" This reverts commit bf3ee1c.
Summary: Relates to #76700 **Overview**: One edge case not accounted for in the original logic of `isGreen` was for commits with no workflow checks. Similarly, if any of the required checks are not present (ex: if all of the pull checks are skipped), the workflow should not be promoteble. A commit should only be promoteable if there is it least one workflow check from each required group present (i.e. none of them are skipped) **Test Plan:** Verify that commits on the HUD with no workflow checks are not considered promote-able. Added a test case with no workflows in `test_print_latest_commits.py` Pull Request resolved: #79565 Approved by: https://github.com/seemethere Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6015987dc387b3703c0e148fe67230f258125ed4 Reviewed By: malfet Differential Revision: D37208283 Pulled By: swang392 fbshipit-source-id: 9b6b5006f576e3a6ad9696143c2e685e5f48c7c5
Relates to pytorch#76700 **Overview**: One edge case not accounted for in the original logic of `isGreen` was for commits with no workflow checks. Similarly, if any of the required checks are not present (ex: if all of the pull checks are skipped), the workflow should not be promoteble. A commit should only be promoteable if there is it least one workflow check from each required group present (i.e. none of them are skipped) **Test Plan:** Verify that commits on the HUD with no workflow checks are not considered promote-able. Added a test case with no workflows in `test_print_latest_commits.py` Pull Request resolved: pytorch#79565 Approved by: https://github.com/seemethere
Relates to #76700
Overview: One edge case not accounted for in the original logic of
isGreenwas for commits with no workflow checks. Similarly, if any of the required checks are not present (ex: if all of the pull checks are skipped), the workflow should not be promoteble. A commit should only be promoteable if there is it least one workflow check from each required group present (i.e. none of them are skipped)Test Plan: Verify that commits on the HUD with no workflow checks are not considered promote-able. Added a test case with no workflows in
test_print_latest_commits.py