Skip to content

Followup fix after #78828#79554

Closed
malfet wants to merge 1 commit intomasterfrom
malfet/fwd-fix-for-78828
Closed

Followup fix after #78828#79554
malfet wants to merge 1 commit intomasterfrom
malfet/fwd-fix-for-78828

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented Jun 14, 2022 •
edited
Loading

Will be skipped when imported internally, for more details see https://www.internalfb.com/diff/D37114156?src_version_fbid=3331368873807344

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 14, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 4e6e641 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet malfet requested a review from suo June 14, 2022 19:37
albanD
albanD approved these changes Jun 14, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@malfet
Copy link
Copy Markdown
Contributor Author

malfet commented Jun 14, 2022

@pytorchbot merge -f

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 14, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 14, 2022

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@malfet malfet deleted the malfet/fwd-fix-for-78828 branch July 17, 2022 18:15
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@malfet @pytorchmergebot
Followup fix after pytorch#78828 (pytorch#79554)
5f1bd72 
Will be skipped when imported internally, for more details see https://www.internalfb.com/diff/D37114156?src_version_fbid=3331368873807344

Pull Request resolved: pytorch#79554
Approved by: https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@suo suo Awaiting requested review from suo

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @facebook-github-bot @pytorchmergebot @albanD