Skip to content

[ONNX] subscribe onnx to our custom test infra#79546

Closed
janeyx99 wants to merge 1 commit intopytorch:masterfrom
janeyx99:migrate-onnx-away-from-unittest.TestCase
Closed

[ONNX] subscribe onnx to our custom test infra#79546
janeyx99 wants to merge 1 commit intopytorch:masterfrom
janeyx99:migrate-onnx-away-from-unittest.TestCase

Conversation

@janeyx99
Copy link
Copy Markdown
Contributor

Remove as many references as can be easily done of unittest in favor of our custom infra.

Left a todo where I could not easily replace unittest.main with run_tests()

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 14, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 1561c69 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@janeyx99 janeyx99 force-pushed the migrate-onnx-away-from-unittest.TestCase branch from 4c6b229 to 1561c69 Compare June 14, 2022 18:06
@janeyx99 janeyx99 requested a review from a team June 14, 2022 19:44
@janeyx99
Copy link
Copy Markdown
Contributor Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

Hey @janeyx99.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 20, 2022
Summary:
Remove as many references as can be easily done of unittest in favor of our custom infra.

Left a todo where I could not easily replace unittest.main with run_tests()

Pull Request resolved: #79546
Approved by: https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d2fbfe7fce9ad2548d299f8122cebefabbe8ecb1

Reviewed By: malfet

Differential Revision: D37208275

Pulled By: janeyx99

fbshipit-source-id: f09858f2115b72074b7dffe54d195968574cf41e
justinchuby pushed a commit to justinchuby/pytorch that referenced this pull request Jul 27, 2022
Remove as many references as can be easily done of unittest in favor of our custom infra.

Left a todo where I could not easily replace unittest.main with run_tests()
Pull Request resolved: pytorch#79546
Approved by: https://github.com/seemethere
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
Remove as many references as can be easily done of unittest in favor of our custom infra.

Left a todo where I could not easily replace unittest.main with run_tests()
Pull Request resolved: pytorch#79546
Approved by: https://github.com/seemethere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants