Skip to content

do not write sccache stats to json if missing OUR_GITHUB_JOB_ID#79541

Closed
jeffdaily wants to merge 1 commit intopytorch:masterfrom
ROCm:relax_github_job_id_requirement
Closed

do not write sccache stats to json if missing OUR_GITHUB_JOB_ID#79541
jeffdaily wants to merge 1 commit intopytorch:masterfrom
ROCm:relax_github_job_id_requirement

Conversation

@jeffdaily
Copy link
Copy Markdown
Collaborator

@jeffdaily jeffdaily commented Jun 14, 2022

Allows use of .jenkins/pytorch/build.sh without assuming OUR_GITHUB_JOB_ID is set. This is a regression caused by #79366.

@jeffdaily jeffdaily requested a review from suo June 14, 2022 17:29
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 14, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 2748339 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@suo
Copy link
Copy Markdown
Member

suo commented Jun 14, 2022

when will this not be set?

@jeffdaily
Copy link
Copy Markdown
Collaborator Author

jeffdaily commented Jun 14, 2022

when will this not be set?

We rely on .jenkins/pytorch/build.sh for a lot of our internal and developer processes, but we use it outside of github. The script tools.stats.sccache_stats_to_json invoked by print_sccache_stats() in .jenkins/pytorch/common_utils.sh assumes the env var exists and fails for builds outside of github.

@suo
Copy link
Copy Markdown
Member

suo commented Jun 14, 2022

ah makes sense

@seemethere
Copy link
Copy Markdown
Member

seemethere commented Jun 14, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 14, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 14, 2022

Hey @jeffdaily.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 16, 2022
@jeffdaily @facebook-github-bot
do not write sccache stats to json if missing OUR_GITHUB_JOB_ID (#79541…
e097f5b 
…) (#79541)

Summary:
Allows use of .jenkins/pytorch/build.sh without assuming OUR_GITHUB_JOB_ID is set.  This is a regression caused by #79366.

Pull Request resolved: #79541
Approved by: https://github.com/suo, https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/adaafeedb1f66c4c877a446a6082f2a761878883

Reviewed By: malfet

Differential Revision: D37156933

fbshipit-source-id: a9309facfccfb8b4aa4f8fb7a727929fe760d95c
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@jeffdaily @pytorchmergebot
do not write sccache stats to json if missing OUR_GITHUB_JOB_ID (pyto…
5478187 
…rch#79541)

Allows use of .jenkins/pytorch/build.sh without assuming OUR_GITHUB_JOB_ID is set.  This is a regression caused by pytorch#79366.
Pull Request resolved: pytorch#79541
Approved by: https://github.com/suo, https://github.com/seemethere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suo suo suo approved these changes

@seemethere seemethere seemethere approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jeffdaily @facebook-github-bot @suo @seemethere @pytorchmergebot @pytorchbot