Enable torch._refs.var for nvFuser executor#79517
Closed
IvanYashchuk wants to merge 2 commits intopytorch:masterfrom
Closed
Enable torch._refs.var for nvFuser executor#79517IvanYashchuk wants to merge 2 commits intopytorch:masterfrom
IvanYashchuk wants to merge 2 commits intopytorch:masterfrom
Conversation
Add variance with correction argument to nvFuser Expose "var" function to Python API Add manual test for prims.var with nvfuser executor
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 2afe2fa (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
mruberry
approved these changes
Jun 14, 2022
Collaborator
mruberry
left a comment
There was a problem hiding this comment.
Stamp from the Meta side
jjsjann123
approved these changes
Jun 14, 2022
Collaborator
jjsjann123
left a comment
There was a problem hiding this comment.
LGTM.
Nitpick on the title of the PR, looks like the nvfuser implementation is added for torch._prims.var instead of _refs.
Collaborator
Author
|
Right, |
Collaborator
Author
|
@pytorchbot merge -g |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Contributor
|
Hey @IvanYashchuk. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 20, 2022
Summary:
This PR adds variance function with correction argument to nvFuser.
Now it's possible to run
```py
import torch
import torch._refs
from torch._prims.executor import make_traced
def foo1(a):
return torch._refs.var(a, keepdim=False, unbiased=False)
def foo2(a):
return torch._refs.var(a, keepdim=False, correction=2)
a = torch.randn(3, 3, device='cuda')
make_traced(foo1)(a, executor="nvfuser")
make_traced(foo2)(a, executor="nvfuser")
```
Pull Request resolved: #79517
Approved by: https://github.com/mruberry, https://github.com/jjsjann123
Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e10b762537214ad152724d772b72b17a4448f145
Reviewed By: malfet
Differential Revision: D37208278
Pulled By: malfet
fbshipit-source-id: 0bda2f5e6c41d73673c23e749cf5836bc4619895
jjsjann123
pushed a commit
to jjsjann123/nvfuser
that referenced
this pull request
Oct 29, 2022
This PR adds variance function with correction argument to nvFuser.
Now it's possible to run
```py
import torch
import torch._refs
from torch._prims.executor import make_traced
def foo1(a):
return torch._refs.var(a, keepdim=False, unbiased=False)
def foo2(a):
return torch._refs.var(a, keepdim=False, correction=2)
a = torch.randn(3, 3, device='cuda')
make_traced(foo1)(a, executor="nvfuser")
make_traced(foo2)(a, executor="nvfuser")
```
Pull Request resolved: pytorch/pytorch#79517
Approved by: https://github.com/mruberry, https://github.com/jjsjann123
jjsjann123
pushed a commit
to jjsjann123/nvfuser
that referenced
this pull request
Nov 10, 2022
This PR adds variance function with correction argument to nvFuser.
Now it's possible to run
```py
import torch
import torch._refs
from torch._prims.executor import make_traced
def foo1(a):
return torch._refs.var(a, keepdim=False, unbiased=False)
def foo2(a):
return torch._refs.var(a, keepdim=False, correction=2)
a = torch.randn(3, 3, device='cuda')
make_traced(foo1)(a, executor="nvfuser")
make_traced(foo2)(a, executor="nvfuser")
```
Pull Request resolved: pytorch/pytorch#79517
Approved by: https://github.com/mruberry, https://github.com/jjsjann123
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
This PR adds variance function with correction argument to nvFuser.
Now it's possible to run
```py
import torch
import torch._refs
from torch._prims.executor import make_traced
def foo1(a):
return torch._refs.var(a, keepdim=False, unbiased=False)
def foo2(a):
return torch._refs.var(a, keepdim=False, correction=2)
a = torch.randn(3, 3, device='cuda')
make_traced(foo1)(a, executor="nvfuser")
make_traced(foo2)(a, executor="nvfuser")
```
Pull Request resolved: pytorch#79517
Approved by: https://github.com/mruberry, https://github.com/jjsjann123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds variance function with correction argument to nvFuser.
Now it's possible to run