Skip to content

ci: Move deploy prefix to job suffix#79436

Closed
seemethere wants to merge 2 commits intogh/seemethere/251/basefrom
gh/seemethere/251/head
Closed

ci: Move deploy prefix to job suffix#79436
seemethere wants to merge 2 commits intogh/seemethere/251/basefrom
gh/seemethere/251/head

Conversation

@seemethere
Copy link
Copy Markdown
Member

@seemethere seemethere commented Jun 13, 2022 •
edited
Loading

Stack from ghstack:

Moves the deply job prefix to a suffix to make it more consistent with
our other job names

Signed-off-by: Eli Uriegas eliuriegas@fb.com

@seemethere
ci: Move deploy prefix to job suffix
6352222 
Moves the deply job prefix to a suffix to make it more consistent with
our other job names

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
@seemethere seemethere requested a review from a team as a code owner June 13, 2022 18:01
This was referenced Jun 13, 2022
Closed
Closed
seemethere added a commit that referenced this pull request Jun 13, 2022
@seemethere
ci: Move deploy prefix to job suffix
9ffd202 
Moves the deply job prefix to a suffix to make it more consistent with
our other job names

Signed-off-by: Eli Uriegas <eliuriegasfb.com>

ghstack-source-id: 2a4776d
Pull Request resolved: #79436
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 13, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 1ddadbe (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@seemethere
Copy link
Copy Markdown
Member Author

seemethere commented Jun 13, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 13, 2022

@pytorchbot successfully started a merge job. Check the current status here

@seemethere
Copy link
Copy Markdown
Member Author

seemethere commented Jun 13, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 13, 2022

@pytorchbot successfully started a merge job. Check the current status here

@seemethere
Copy link
Copy Markdown
Member Author

seemethere commented Jun 20, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 20, 2022

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 20, 2022

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/master gh/seemethere/251/orig returned non-zero exit code 1

Rebasing (1/3)
Auto-merging .github/workflows/pull.yml
CONFLICT (content): Merge conflict in .github/workflows/pull.yml
error: could not apply e7e05bf7ee... ci: Remove pytorch- prefix from xla job name
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply e7e05bf7ee... ci: Remove pytorch- prefix from xla job name

Raised by https://github.com/pytorch/pytorch/actions/runs/2532035248

@seemethere
Update on "ci: Move deploy prefix to job suffix"
1ddadbe 
Moves the deply job prefix to a suffix to make it more consistent with
our other job names

Signed-off-by: Eli Uriegas <eliuriegasfb.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request Jun 21, 2022
@seemethere
ci: Move deploy prefix to job suffix
96dec8e 
Moves the deply job prefix to a suffix to make it more consistent with
our other job names

Signed-off-by: Eli Uriegas <eliuriegasfb.com>

ghstack-source-id: 3361d09
Pull Request resolved: #79436
@seemethere
Copy link
Copy Markdown
Member Author

seemethere commented Jun 21, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 21, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 21, 2022

Hey @seemethere.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 22, 2022
@seemethere @facebook-github-bot
ci: Move deploy prefix to job suffix (#79436)
b8239b5 
Summary:
Moves the deply job prefix to a suffix to make it more consistent with
our other job names

Signed-off-by: Eli Uriegas <eliuriegasfb.com>

Pull Request resolved: #79436

Approved by: https://github.com/janeyx99

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/290e95d35aa0661f417437fd933b2612f078de68

Reviewed By: atalman

Differential Revision: D37327378

Pulled By: seemethere

fbshipit-source-id: cb0d07d9a1872c4a1d8f839b98135fca5e3e5167
@facebook-github-bot facebook-github-bot deleted the gh/seemethere/251/head branch June 25, 2022 14:16
miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022
@seemethere @miladm
ci: Move deploy prefix to job suffix
a66e7e2 
Moves the deply job prefix to a suffix to make it more consistent with
our other job names

Signed-off-by: Eli Uriegas <eliuriegasfb.com>

Pull Request resolved: pytorch#79436

Approved by: https://github.com/janeyx99
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@seemethere @pytorchmergebot
ci: Move deploy prefix to job suffix
315891c 
Moves the deply job prefix to a suffix to make it more consistent with
our other job names

Signed-off-by: Eli Uriegas <eliuriegasfb.com>

Pull Request resolved: pytorch#79436

Approved by: https://github.com/janeyx99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seemethere @facebook-github-bot @pytorchmergebot @malfet @janeyx99