Skip to content

Fixes maybe_broadcast to actually broadcast only when needed#79298

Closed
mruberry wants to merge 4 commits intomasterfrom
more_refs
Closed

Fixes maybe_broadcast to actually broadcast only when needed#79298
mruberry wants to merge 4 commits intomasterfrom
more_refs

Conversation

@mruberry
Copy link
Copy Markdown
Collaborator

@mruberry mruberry commented Jun 10, 2022

Adds a same_shape util and updates maybe_broadcast to use it; previously maybe_broadcast was always broadcasting because its equality check was always failing.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 10, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 6e05b62 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@mruberry
Copy link
Copy Markdown
Collaborator Author

mruberry commented Jun 11, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 11, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 11, 2022

Hey @mruberry.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@suo
Copy link
Copy Markdown
Member

suo commented Jun 11, 2022

@pytorchbot revert -m "Broke FakeTensor tests on master, see: https://hud.pytorch.org/pytorch/pytorch/commit/1cb1c2c08cf8d4ce62d3d861b931df2e579872c0" -c landrace

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 11, 2022

@pytorchbot successfully started a revert job. Check the current status here

pytorchmergebot added a commit that referenced this pull request Jun 11, 2022
@pytorchmergebot
Revert "Fixes maybe_broadcast to actually broadcast only when needed (#…
66460c4 
…79298)"

This reverts commit 1cb1c2c.

Reverted #79298 on behalf of https://github.com/suo due to Broke FakeTensor tests on master, see: https://hud.pytorch.org/pytorch/pytorch/commit/1cb1c2c08cf8d4ce62d3d861b931df2e579872c0
@janeyx99 janeyx99 mentioned this pull request Jun 17, 2022
Closed
@mruberry mruberry reopened this Jun 21, 2022
@mruberry mruberry requested a review from ngimel as a code owner June 21, 2022 15:03
@mruberry mruberry added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 21, 2022
@mruberry
Copy link
Copy Markdown
Collaborator Author

mruberry commented Jun 21, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 21, 2022

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 21, 2022

@mruberry your PR has been successfully merged.

facebook-github-bot pushed a commit that referenced this pull request Jun 22, 2022
@facebook-github-bot
Fixes maybe_broadcast to actually broadcast only when needed (#79298) (…
cca57b3 
…#79298)

Summary:
Adds a `same_shape` util and updates maybe_broadcast to use it; previously maybe_broadcast was always broadcasting because its equality check was always failing.

Pull Request resolved: #79298
Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/ca845462a014a7f45c5a10a14421362f3a6da1a7

Reviewed By: atalman

Differential Revision: D37327395

Pulled By: mruberry

fbshipit-source-id: fba03e90c54ea787a63b31741cbb78e6d3669b5e
miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022
@miladm
Fixes maybe_broadcast to actually broadcast only when needed (pytorch…
7d63bcd 
…#79298)

Adds a `same_shape` util and updates maybe_broadcast to use it; previously maybe_broadcast was always broadcasting because its equality check was always failing.
Pull Request resolved: pytorch#79298
Approved by: https://github.com/ezyang
@github-actions github-actions Bot deleted the more_refs branch February 17, 2024 01:52
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@pytorchmergebot
Fixes maybe_broadcast to actually broadcast only when needed (pytorch…
09b3b16 
…#79298)

Adds a `same_shape` util and updates maybe_broadcast to use it; previously maybe_broadcast was always broadcasting because its equality check was always failing.
Pull Request resolved: pytorch#79298
Approved by: https://github.com/ezyang
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@pytorchmergebot
Revert "Fixes maybe_broadcast to actually broadcast only when needed (p…
f23048d 
…ytorch#79298)"

This reverts commit 09b3b16.

Reverted pytorch#79298 on behalf of https://github.com/suo due to Broke FakeTensor tests on master, see: https://hud.pytorch.org/pytorch/pytorch/commit/09b3b16ae7ab7156ca0afd3b5191feabcc79f719
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@pytorchmergebot
Fixes maybe_broadcast to actually broadcast only when needed (pytorch…
9794d0d 
…#79298)

Adds a `same_shape` util and updates maybe_broadcast to use it; previously maybe_broadcast was always broadcasting because its equality check was always failing.
Pull Request resolved: pytorch#79298
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged module: primTorch Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mruberry @facebook-github-bot @pytorchmergebot @suo @ezyang