[const_fold] Set requires_grad based on the folded tensor; add device_for_folding option#79067
[const_fold] Set requires_grad based on the folded tensor; add device_for_folding option#79067jfix71 wants to merge 1 commit intopytorch:masterfrom
Conversation
🔗 Helpful links
✅ No Failures (0 Pending)As of commit b1cdc1c (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D36975932 |
dborkovic
left a comment
There was a problem hiding this comment.
Other than checking that the results are equal in line 670, do we need to check that the graph structure has changed in any particular fashion?
…_for_folding option (pytorch#90) Summary: X-link: meta-pytorch/fx2trt#90 Pull Request resolved: pytorch#79067 att Test Plan: Added unit test coverage for tensor_meta part. Reviewed By: yinghai Differential Revision: D36975932 fbshipit-source-id: 228bc2d501f411b6fc2aeeb7efe5140a631697ea
|
This pull request was exported from Phabricator. Differential Revision: D36975932 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @jfix71. |
…_for_folding option (#90) Summary: X-link: meta-pytorch/fx2trt#90 Pull Request resolved: #79067 att Test Plan: Added unit test coverage for tensor_meta part. Reviewed By: yinghai Differential Revision: D36975932 fbshipit-source-id: 17e309b17b3ba66cda0e7d5712089d860a5e125e
Summary: att
Test Plan: Added unit test coverage for tensor_meta part.
Reviewed By: wushirong
Differential Revision: D36975932