Skip to content

Allow torchdispatch to customize dim()#78691

Closed
suo wants to merge 3 commits intogh/suo/534/basefrom
gh/suo/534/head
Closed

Allow torchdispatch to customize dim()#78691
suo wants to merge 3 commits intogh/suo/534/basefrom
gh/suo/534/head

Conversation

@suo
Copy link
Member

@suo suo commented Jun 2, 2022 •
edited
Loading

@suo
Allow torchdispatch to customize dim()
75a842a 
This follows the template in
#77396

[ghstack-poisoned]
@suo suo requested review from albanD and soulitzer as code owners June 2, 2022 02:08
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 2, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 0c53b4a (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

suo added a commit that referenced this pull request Jun 2, 2022
@suo
Allow torchdispatch to customize dim()
f1b4ade 
This follows the template in
#77396

ghstack-source-id: 9b6a786
Pull Request resolved: #78691
@suo
Copy link
Member Author

suo commented Jun 2, 2022

I still need to thread symints through this, but will do that in a followup

@suo suo requested a review from ezyang June 2, 2022 02:17
ezyang
ezyang approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW I kind of wondered if we should have one more policy distinction between custom sizes and custom dim; e.g., maybe the sizes are symbolic but the dim is fixed. IDK, maybe not worth.

@suo
Copy link
Member Author

suo commented Jun 2, 2022

We only have 2 bits for it, so that would be the last policy unless we wanted to make it bigger (our bitfield is currently 14 bits so I guess we could probably stick 2 more in there).

@suo
Copy link
Member Author

suo commented Jun 2, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 2, 2022

Merge failed due to Refusing to merge as mandatory check(s) win-vs2019-cpu-py3 / build, win-vs2019-cuda11.3-py3 / build failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2425752861

@ezyang
Copy link
Contributor

ezyang commented Jun 2, 2022

isn't -g the wrong flag, you should use -a?

@suo
Copy link
Member Author

suo commented Jun 2, 2022

yes oops

@suo
Update on "Allow torchdispatch to customize dim()"
8247a8f 
This follows the template in
#77396

[ghstack-poisoned]
@suo
Update on "Allow torchdispatch to customize dim()"
0c53b4a 
This follows the template in
#77396

[ghstack-poisoned]
suo added a commit that referenced this pull request Jun 2, 2022
@suo
Allow torchdispatch to customize dim()
1428bc6 
This follows the template in
#77396

ghstack-source-id: c21da4c
Pull Request resolved: #78691
@suo
Copy link
Member Author

suo commented Jun 2, 2022

@pytorchbot merge

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Hey @suo.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 3, 2022
@suo @facebook-github-bot
Allow torchdispatch to customize dim() (#78691)
2dbd887 
Summary:
This follows the template in
#77396

Pull Request resolved: #78691

Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/22b10873f375cb0d582f4567525238f716c430ca

Reviewed By: malfet, b0noI

Differential Revision: D36882361

fbshipit-source-id: 67b95f50c40b09514d958526bc6126d314cce7c5
@facebook-github-bot facebook-github-bot deleted the gh/suo/534/head branch June 6, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suo @facebook-github-bot @pytorchmergebot @ezyang