Skip to content

[cuDNN V8 API] (reopen 2) Allow the number of kernels profiled under torch.backends.cudnn.benchmark = True to be limitedCudnnv8 benchmark limit#78299

Closed
eqy wants to merge 13 commits intopytorch:masterfrom
eqy:cudnnv8_benchmark_limit
Closed

[cuDNN V8 API] (reopen 2) Allow the number of kernels profiled under torch.backends.cudnn.benchmark = True to be limitedCudnnv8 benchmark limit#78299
eqy wants to merge 13 commits intopytorch:masterfrom
eqy:cudnnv8_benchmark_limit

Conversation

@eqy
Copy link
Collaborator

@eqy eqy commented May 25, 2022

Reopen of #77002 to address comments by @malfet

CC @ngimel @ptrblck

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 25, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 58b21c2 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@dagitses dagitses requested a review from malfet May 31, 2022 14:18
@dagitses dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 31, 2022
@dagitses dagitses requested a review from ngimel May 31, 2022 14:19
@eqy eqy force-pushed the cudnnv8_benchmark_limit branch from 42ed219 to 6e15bcd Compare July 7, 2022 03:30
@eqy eqy force-pushed the cudnnv8_benchmark_limit branch from ecc5742 to 58b21c2 Compare July 7, 2022 16:11
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 7, 2022

@ngimel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ngimel
Copy link
Collaborator

ngimel commented Jul 7, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 7, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Hey @eqy.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 8, 2022
@eqy @facebook-github-bot
[cuDNN V8 API] (reopen 2) Allow the number of kernels profiled under …
dd1a3b7 
…torch.backends.cudnn.benchmark = True to be limitedCudnnv8 benchmark limit (#78299) (#78299)

Summary:
Reopen of #77002 to address comments by malfet

CC ngimel ptrblck

Pull Request resolved: #78299
Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/ae6dd20ba7725ea7c10d759f82891d86eb724c11

Reviewed By: mehtanirav, cpuhrsch

Differential Revision: D37690491

fbshipit-source-id: 6c603a706663dcc7086755a5d4b6e382233dad7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees

@malfet malfet

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@eqy @facebook-github-bot @ngimel @pytorchmergebot @malfet @dagitses @pytorchbot