Skip to content

[GHF] Better "Reviews missing" error message#78219

Closed
malfet wants to merge 1 commit intomasterfrom
malfet/ghf-better-needs-review-message
Closed

[GHF] Better "Reviews missing" error message#78219
malfet wants to merge 1 commit intomasterfrom
malfet/ghf-better-needs-review-message

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented May 24, 2022 •
edited
Loading

When merging stack, it could be confusing to see which PRs are missing
reviews as one can observe in #77667 (comment)

Print PR number in needs-review message

@malfet
[GHF] Better "Reviews missing" error message
1533d5d 
When merging stack, it could be confusing to see which PRs are missing
reviews as one can observe in #77667 (comment)

Print PR number in needs-review message
@malfet malfet requested a review from a team as a code owner May 24, 2022 22:16
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 24, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 1533d5d (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet
Copy link
Contributor Author

malfet commented May 24, 2022

@pytorchbot force merge this

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2022

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@malfet malfet added the topic: not user facing topic category label May 24, 2022
@malfet malfet deleted the malfet/ghf-better-needs-review-message branch May 24, 2022 23:48
facebook-github-bot pushed a commit that referenced this pull request May 26, 2022
@malfet @facebook-github-bot
[GHF] Better "Reviews missing" error message (#78219) (#78219)
ce49483 
Summary:
When merging stack, it could be confusing to see which PRs are missing
reviews as one can observe in #77667 (comment)

Print PR number in needs-review message

Pull Request resolved: #78219
Approved by: https://github.com/atalman, https://github.com/kit1980, https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/357707b9f9b09eef2e50d2ba035f1c694be6018e

Reviewed By: mehtanirav

Differential Revision: D36668860

Pulled By: malfet

fbshipit-source-id: fb08f0b747f75ef4bdd9d49a52a33b7ed0022877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@atalman atalman atalman approved these changes

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@malfet @facebook-github-bot @kit1980 @seemethere @atalman @pytorchmergebot