Skip to content

reland of as_strided support for functionalization; introduce as_strided_scatter#78199

Closed
bdhirsh wants to merge 1 commit intogh/bdhirsh/241/basefrom
gh/bdhirsh/241/head
Closed

reland of as_strided support for functionalization; introduce as_strided_scatter#78199
bdhirsh wants to merge 1 commit intogh/bdhirsh/241/basefrom
gh/bdhirsh/241/head

Conversation

@bdhirsh
Copy link
Collaborator

@bdhirsh bdhirsh commented May 24, 2022 •
edited
Loading

Reland of #77128 which broke some master-only ROCM tests

I had to add an extra skip to the OpInfo tests - re-running with ci/all before re-landing

Stack from ghstack:

This reverts commit a95f1ed.

@bdhirsh
reland of as_strided support for functionalization; introduce as_stri…
6225413 
…ded_scatter

This reverts commit a95f1ed.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 24, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 6225413 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

bdhirsh added a commit that referenced this pull request May 24, 2022
@bdhirsh
reland of as_strided support for functionalization; introduce as_stri…
bbcea6f 
…ded_scatter

This reverts commit a95f1ed.

ghstack-source-id: 5686bb8
Pull Request resolved: #78199
@bdhirsh bdhirsh requested a review from ezyang May 24, 2022 20:29
@bdhirsh bdhirsh added the ciflow/trunk Trigger trunk jobs on your pull request label May 24, 2022
@bdhirsh
Copy link
Collaborator Author

bdhirsh commented May 24, 2022

@pytorchbot merge -g

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2022

Hey @bdhirsh.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request May 26, 2022
@bdhirsh @facebook-github-bot
reland of as_strided support for functionalization; introduce as_stri…
56f0c8f 
…ded_scatter (#78199)

Summary:
This reverts commit a95f1ed.

Pull Request resolved: #78199

Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/07e45334038e6ddb5dfb9ba2c9da10da4e8e1e8b

Reviewed By: mehtanirav

Differential Revision: D36668774

Pulled By: bdhirsh

fbshipit-source-id: 91b9a2cdbbd5cf1de7e22136bf566f093ede4238
@facebook-github-bot facebook-github-bot deleted the gh/bdhirsh/241/head branch May 28, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@ngimel ngimel Awaiting requested review from ngimel

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bdhirsh @facebook-github-bot @ezyang @pytorchmergebot