Closed
Conversation
Use `instancesRespondToSelector:` to test the presence of `optimizationLevel` in `MPSGraphCompilationDescriptor`, which according to https://developer.apple.com/documentation/metalperformanceshadersgraph/mpsgraphcompilationdescriptor/3922624-optimizationlevel is only available on 12.3 or newer This works around a limitations of `@available(macOS 12.3, *)` macro in shared libraries dynamically loaded by apps targeting older runtime. And deployment target for macos Python conda binaries is 10.14: ``` % otool -l `which python3` ... Load command 9 cmd LC_BUILD_VERSION cmdsize 32 platform 1 minos 10.14 sdk 10.14 ... ```
Contributor
🔗 Helpful links
✅ No Failures (18 Pending)As of commit 48fd2d7 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
seemethere
approved these changes
May 24, 2022
Contributor
Author
|
@pytorchbot merge this |
Collaborator
|
Merge failed due to Refusing to merge as mandatory check(s)linux-docs / build-docs (cpp) failed for rule superuser |
Contributor
Author
|
@pytorchbot force merge this as windows failures exists on trunk |
Contributor
|
Hey @malfet. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 26, 2022
Summary: Use `instancesRespondToSelector:` to test the presence of `optimizationLevel` in `MPSGraphCompilationDescriptor`, which according to https://developer.apple.com/documentation/metalperformanceshadersgraph/mpsgraphcompilationdescriptor/3922624-optimizationlevel is only available on 12.3 or newer This works around a limitations of `available(macOS 12.3, *)` macro in shared libraries dynamically loaded by apps targeting older runtime. And deployment target for macos Python conda binaries is 10.14: ``` % otool -l `which python3` ... Load command 9 cmd LC_BUILD_VERSION cmdsize 32 platform 1 minos 10.14 sdk 10.14 ... ``` Pull Request resolved: #78192 Approved by: https://github.com/atalman, https://github.com/seemethere Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b7bb34d7625d95e5088638721dcc07c2bc5e2ade Reviewed By: mehtanirav Differential Revision: D36668764 Pulled By: malfet fbshipit-source-id: fa4d03a15ea19159a039526e68b2c28722b75493
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Jun 6, 2022
Use `instancesRespondToSelector:` to test the presence of `optimizationLevel` in `MPSGraphCompilationDescriptor`, which according to https://developer.apple.com/documentation/metalperformanceshadersgraph/mpsgraphcompilationdescriptor/3922624-optimizationlevel is only available on 12.3 or newer This works around a limitations of `@available(macOS 12.3, *)` macro in shared libraries dynamically loaded by apps targeting older runtime. And deployment target for macos Python conda binaries is 10.14: ``` % otool -l `which python3` ... Load command 9 cmd LC_BUILD_VERSION cmdsize 32 platform 1 minos 10.14 sdk 10.14 ... ``` Pull Request resolved: pytorch#78192 Approved by: https://github.com/atalman, https://github.com/seemethere
malfet
added a commit
that referenced
this pull request
Jun 7, 2022
Use `instancesRespondToSelector:` to test the presence of `optimizationLevel` in `MPSGraphCompilationDescriptor`, which according to https://developer.apple.com/documentation/metalperformanceshadersgraph/mpsgraphcompilationdescriptor/3922624-optimizationlevel is only available on 12.3 or newer This works around a limitations of `@available(macOS 12.3, *)` macro in shared libraries dynamically loaded by apps targeting older runtime. And deployment target for macos Python conda binaries is 10.14: ``` % otool -l `which python3` ... Load command 9 cmd LC_BUILD_VERSION cmdsize 32 platform 1 minos 10.14 sdk 10.14 ... ``` Pull Request resolved: #78192 Approved by: https://github.com/atalman, https://github.com/seemethere (cherry picked from commit b7bb34d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
instancesRespondToSelector:to test the presence ofoptimizationLevelinMPSGraphCompilationDescriptor, which accordingto
https://developer.apple.com/documentation/metalperformanceshadersgraph/mpsgraphcompilationdescriptor/3922624-optimizationlevel
is only available on 12.3 or newer
This works around a limitations of
@available(macOS 12.3, *)macro inshared libraries dynamically loaded by apps targeting older runtime.
And deployment target for macos Python conda binaries is 10.14: