Skip to content

[CUDAGraphs] Add an argument to specify warmup iterations in make_graphed_callables#78124

Closed
GD06 wants to merge 1 commit intopytorch:masterfrom
GD06:export-D36606758
Closed

[CUDAGraphs] Add an argument to specify warmup iterations in make_graphed_callables#78124
GD06 wants to merge 1 commit intopytorch:masterfrom
GD06:export-D36606758

Conversation

@GD06
Copy link
Contributor

@GD06 GD06 commented May 23, 2022

Summary: Add an argument to specify the number of warmup iterations to the API torch.cuda.make_graphed_callables. By default, it needs 3 warm-up iterations. To work with NCCL, it needs 11 warm-up iterations.

Differential Revision: D36606758

@facebook-github-bot
Add an argument to specify warmup iterations
5227449 
Summary: Add an argument to specify the number of warmup iterations to the API ``torch.cuda.make_graphed_callables``. By default, it needs 3 warm-up iterations. To work with NCCL, it needs 11 warm-up iterations.

Differential Revision: D36606758

fbshipit-source-id: bce980da8cfc7c5e686c2d13f9a4a152c54fa7a3
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 23, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 5227449 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 23, 2022

This pull request was exported from Phabricator. Differential Revision: D36606758

@jianyuh jianyuh requested a review from mcarilli May 24, 2022 23:55
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 25, 2022

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022

Hey @GD06.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request May 25, 2022
@facebook-github-bot
Add an argument to specify warmup iterations (#78124)
c717f2e 
Summary:
Pull Request resolved: #78124

Add an argument to specify the number of warmup iterations to the API ``torch.cuda.make_graphed_callables``. By default, it needs 3 warm-up iterations. To work with NCCL, it needs 11 warm-up iterations.

Reviewed By: jianyuh

Differential Revision: D36606758

fbshipit-source-id: a160cf4fa8b1171546cc65c240f47aa1fbf7ec6e
@ngimel ngimel changed the title Add an argument to specify warmup iterations [CUDAGraphs] Add an argument to specify warmup iterations in make_graphed_callables Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianyuh jianyuh jianyuh approved these changes

@mcarilli mcarilli Awaiting requested review from mcarilli

Assignees

No one assigned

Labels

cla signed fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GD06 @facebook-github-bot @jianyuh @pytorchmergebot