have a common interface to extract metadata from SizeNodes#78088
have a common interface to extract metadata from SizeNodes#78088Krovatkin wants to merge 1 commit intopytorch:masterfrom
Conversation
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 14971d4 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
34029fe to
e8497b8
Compare
There was a problem hiding this comment.
Ah, this is neat. How are we going to represent a common SizeNode in the LTC code path? Is it going to be shared_ptr< DimensionNode> ?
There was a problem hiding this comment.
Correct! I think I should just add a test. Initially, I just wanted to get @miladm to try it out w/ his PR :)
There was a problem hiding this comment.
I thought we are supposed to use <> inports.
There was a problem hiding this comment.
yes we are... that's clang-tidy :(
|
FIXES #77880 |
bcc6f68 to
579d295
Compare
have a common interface to extract metadata from SizeNodes
e8ded00 to
14971d4
Compare
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @Krovatkin. |
…78088) Summary: Fixes #ISSUE_NUMBER Pull Request resolved: #78088 Approved by: https://github.com/JackCaoG, https://github.com/wconstab Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/83e575c51024746b9f5174d1d924657891bb99e9 Reviewed By: malfet Differential Revision: D37208289 Pulled By: Krovatkin fbshipit-source-id: c2bb988b391d0e849079afef6573fbb3ae324785
…8088) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#78088 Approved by: https://github.com/JackCaoG, https://github.com/wconstab
Fixes #ISSUE_NUMBER