Skip to content

remove torch.no_grad from sample_inputs#78076

Closed
kshitij12345 wants to merge 1 commit intopytorch:masterfrom
kshitij12345:minor/remove-torch-no-grad-opinfo
Closed

remove torch.no_grad from sample_inputs#78076
kshitij12345 wants to merge 1 commit intopytorch:masterfrom
kshitij12345:minor/remove-torch-no-grad-opinfo

Conversation

@kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented May 23, 2022 •
edited
Loading

As per title

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 23, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 4e514c4 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kshitij12345 kshitij12345 changed the title remove torch.no from sample_inputs remove torch.no_grad from sample_inputs May 23, 2022
@kshitij12345 kshitij12345 requested a review from lezcano May 23, 2022 13:16
@kshitij12345 kshitij12345 marked this pull request as ready for review May 23, 2022 13:16
lezcano
lezcano approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what the CI has to say

@kshitij12345
Copy link
Collaborator Author

kshitij12345 commented May 25, 2022

Gentle ping @ngimel @mruberry

@ngimel
Copy link
Collaborator

ngimel commented May 25, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022

Hey @kshitij12345.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request May 26, 2022
@kshitij12345 @facebook-github-bot
remove torch.no_grad from sample_inputs (#78076) (#78076)
62c88d5 
Summary:
As per title

Pull Request resolved: #78076
Approved by: https://github.com/Lezcano, https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/17c1aed2b57f84d9fe37932c08c8feca04f5d821

Reviewed By: mehtanirav

Differential Revision: D36668878

fbshipit-source-id: cf0e8ed846a6557bf0bfa9bb0fb8934d2b114924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezcano lezcano lezcano approved these changes

@ngimel ngimel ngimel approved these changes

@mruberry mruberry Awaiting requested review from mruberry

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kshitij12345 @facebook-github-bot @ngimel @lezcano @pytorchbot @pytorchmergebot