Skip to content

Add meta device support to _UntypedStorage and _TypedStorage#78008

Closed
kurtamohler wants to merge 1 commit intopytorch:masterfrom
kurtamohler:storage-meta
Closed

Add meta device support to _UntypedStorage and _TypedStorage#78008
kurtamohler wants to merge 1 commit intopytorch:masterfrom
kurtamohler:storage-meta

Conversation

@kurtamohler
Copy link
Collaborator

@kurtamohler kurtamohler commented May 20, 2022

Fixes #77885

@kurtamohler kurtamohler added module: internals Related to internal abstractions in c10 and ATen module: meta tensors labels May 20, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 20, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 75b566a (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kurtamohler
Copy link
Collaborator Author

kurtamohler commented May 20, 2022

It's very possible that some of the functions for a meta storage will fail in an ugly way at the moment (like assuming that the data pointer is valid and trying to access it). I will take a look into all of them

@kurtamohler kurtamohler force-pushed the storage-meta branch 2 times, most recently from 3e95a93 to 0c42edd Compare May 20, 2022 23:11
@ezyang ezyang mentioned this pull request May 23, 2022
Closed
@kurtamohler kurtamohler marked this pull request as ready for review May 27, 2022 16:24
@kurtamohler kurtamohler force-pushed the storage-meta branch 4 times, most recently from 08ec2cb to 3c0dd84 Compare May 27, 2022 19:55
@ezyang
Copy link
Contributor

ezyang commented May 27, 2022

Need to disable the test when run on xla

@ezyang
Copy link
Contributor

ezyang commented May 28, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2022

Hey @kurtamohler.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 1, 2022
@kurtamohler @facebook-github-bot
Add meta device support to _UntypedStorage and _TypedStorage (#78008
61c00ea 
) (#78008)

Summary:
Fixes #77885

Pull Request resolved: #78008
Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e9afb43676a2427d0437198995a83165b41a39b5

Reviewed By: seemethere

Differential Revision: D36783688

Pulled By: seemethere

fbshipit-source-id: 965157d25639efe19876c17522b75956d9049a48
@kurtamohler kurtamohler mentioned this pull request Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: internals Related to internal abstractions in c10 and ATen module: meta tensors open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add meta device support for Storages

5 participants

@kurtamohler @facebook-github-bot @ezyang @pytorchbot @pytorchmergebot