Skip to content

add slow path for is_contiguous#77906

Closed
george-qi wants to merge 1 commit intopytorch:masterfrom
george-qi:export-D36493890
Closed

add slow path for is_contiguous#77906
george-qi wants to merge 1 commit intopytorch:masterfrom
george-qi:export-D36493890

Conversation

@george-qi
Copy link
Contributor

@george-qi george-qi commented May 19, 2022

Test Plan: CI

Reviewed By: malfet, b0noI

Differential Revision: D36493890

@george-qi @facebook-github-bot
add slow path for is_contiguous
615826c 
Test Plan: CI

Reviewed By: malfet, b0noI

Differential Revision: D36493890

fbshipit-source-id: 09571305a2b87209d061fd0b9bea8f882f338d26
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 19, 2022 •
edited
Loading

🔗 Helpful links

❌ 2 New Failures

As of commit 615826c (more details on the Dr. CI page):

Expand to see more
  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-xenial-cuda11.3-py3.7-gcc7 / test (default, 2, 4, linux.4xlarge.nvidia.gpu) (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-19T23:58:33.3691130Z RuntimeError: test_meta failed! 
2022-05-19T23:58:31.4876016Z FAILED (errors=13, skipped=21, expected failures=39)
2022-05-19T23:58:31.4876223Z 
2022-05-19T23:58:31.4876346Z Generating XML reports...
2022-05-19T23:58:32.5821927Z Generated XML report: test-reports/python-unittest/test_meta/TEST-TestMetaCUDA-20220519231853.xml
2022-05-19T23:58:32.5832249Z Generated XML report: test-reports/python-unittest/test_meta/TEST-TestMetaConverter-20220519231853.xml
2022-05-19T23:58:33.3684273Z Traceback (most recent call last):
2022-05-19T23:58:33.3684655Z   File "test/run_test.py", line 1074, in <module>
2022-05-19T23:58:33.3687704Z     main()
2022-05-19T23:58:33.3688507Z   File "test/run_test.py", line 1052, in main
2022-05-19T23:58:33.3690795Z     raise RuntimeError(err_message)
2022-05-19T23:58:33.3691130Z RuntimeError: test_meta failed!
2022-05-19T23:58:33.8862148Z + cleanup
2022-05-19T23:58:33.8862422Z + retcode=1
2022-05-19T23:58:33.8862660Z + set +x
2022-05-19T23:58:33.8909601Z ##[error]Process completed with exit code 1.
2022-05-19T23:58:33.8954990Z ##[group]Run pytorch/pytorch/.github/actions/get-workflow-job-id@master
2022-05-19T23:58:33.8955332Z with:
2022-05-19T23:58:33.8955864Z   github-token: ***
2022-05-19T23:58:33.8956101Z env:
2022-05-19T23:58:33.8956311Z   IN_CI: 1
2022-05-19T23:58:33.8956511Z   IS_GHA: 1

See GitHub Actions build pull / linux-bionic-rocm5.1-py3.7 / test (default, 1, 2, linux.rocm.gpu) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-20T01:03:50.8062989Z RuntimeError: test_meta failed! 
2022-05-20T01:03:47.0557946Z FAILED (errors=13, skipped=130, expected failures=39)
2022-05-20T01:03:47.0558139Z 
2022-05-20T01:03:47.0558238Z Generating XML reports...
2022-05-20T01:03:47.8310287Z Generated XML report: test-reports/python-unittest/test_meta/TEST-TestMetaCUDA-20220520004845.xml
2022-05-20T01:03:47.8314925Z Generated XML report: test-reports/python-unittest/test_meta/TEST-TestMetaConverter-20220520004845.xml
2022-05-20T01:03:50.8047748Z Traceback (most recent call last):
2022-05-20T01:03:50.8049377Z   File "test/run_test.py", line 1074, in <module>
2022-05-20T01:03:50.8054795Z     main()
2022-05-20T01:03:50.8056100Z   File "test/run_test.py", line 1052, in main
2022-05-20T01:03:50.8061549Z     raise RuntimeError(err_message)
2022-05-20T01:03:50.8062989Z RuntimeError: test_meta failed!
2022-05-20T01:03:51.9450523Z 
2022-05-20T01:03:51.9452092Z real	43m58.698s
2022-05-20T01:03:51.9453354Z user	45m2.239s
2022-05-20T01:03:51.9454285Z sys	3m33.734s
2022-05-20T01:03:51.9454838Z + cleanup
2022-05-20T01:03:51.9455340Z + retcode=1
2022-05-20T01:03:51.9455855Z + set +x
2022-05-20T01:03:51.9596352Z ##[error]Process completed with exit code 1.
2022-05-20T01:03:51.9697233Z ##[group]Run # copy test results back to the mounted workspace, needed sudo, resulting permissions were correct
2022-05-20T01:03:51.9697777Z �[36;1m# copy test results back to the mounted workspace, needed sudo, resulting permissions were correct�[0m
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 19, 2022

This pull request was exported from Phabricator. Differential Revision: D36493890

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 19, 2022

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

facebook-github-bot pushed a commit that referenced this pull request May 19, 2022
@george-qi @facebook-github-bot
add slow path for is_contiguous (#77906)
e7cb95a 
Summary:
Pull Request resolved: #77906

This is a re-landing of #77396 with a patch to torchdistx so that internal CI's don't break

Test Plan: CI

Reviewed By: malfet, b0noI

Differential Revision: D36493890

fbshipit-source-id: 8373f0bfa3803d2c8bc6dd5178b13205c39ea1f0
@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2022

Hey @george-qi.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

cla signed fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@george-qi @facebook-github-bot @malfet @pytorchmergebot