Skip to content

[ROCm] Enable some sparse tests on ROCm#77877

Closed
jpvillam-amd wants to merge 2 commits intopytorch:masterfrom
ROCm:rocm_sparse_enable
Closed

[ROCm] Enable some sparse tests on ROCm#77877
jpvillam-amd wants to merge 2 commits intopytorch:masterfrom
ROCm:rocm_sparse_enable

Conversation

@jpvillam-amd
Copy link
Copy Markdown
Contributor

@jpvillam-amd jpvillam-amd commented May 19, 2022

Enabling:
test_sampled_addmm_errors_cuda_complex128
test_sampled_addmm_errors_cuda_complex64
test_sampled_addmm_errors_cuda_float32
test_sampled_addmm_errors_cuda_float64
test_sparse_add_cuda_complex128
test_sparse_add_cuda_complex64

@pytorch-bot pytorch-bot Bot added the module: rocm AMD GPU support for Pytorch label May 19, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 19, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit ab912be (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@jpvillam-amd jpvillam-amd changed the title [ROCM] Enable some sparse tests on ROCM [ROCm] Enable some sparse tests on ROCm May 19, 2022
@pruthvistony pruthvistony added the ciflow/trunk Trigger trunk jobs on your pull request label May 29, 2022
@ejguan ejguan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 31, 2022
@pruthvistony
Copy link
Copy Markdown
Collaborator

pruthvistony commented Jun 9, 2022

@jpvillam-amd ,
Please check few tests are still getting skipped in the CI run
test_sampled_addmm_errors_cuda_complex64 (main.TestSparseCSRCUDA) ... skip: cuSparse Generic API SDDMM is not available (0.003s)
test_sampled_addmm_errors_cuda_float32 (main.TestSparseCSRCUDA) ... skip: cuSparse Generic API SDDMM is not available (0.003s)
test_sampled_addmm_errors_cuda_float64 (main.TestSparseCSRCUDA) ... skip: cuSparse Generic API SDDMM is not available (0.003s)
test_sampled_addmm_zero_sized_cuda_complex128 (main.TestSparseCSRCUDA) ... skip: test doesn't currently work on the ROCm stack (0.002s)

@jpvillam-amd
Copy link
Copy Markdown
Contributor Author

jpvillam-amd commented Jun 10, 2022

From https://github.com/pytorch/pytorch/runs/6819237934?check_suite_focus=true#step:7:48957:

  test_sampled_addmm_errors_cuda_complex128 (__main__.TestSparseCSRCUDA) ... ok (0.033s)
  test_sampled_addmm_errors_cuda_complex64 (__main__.TestSparseCSRCUDA) ... ok (0.032s)
  test_sampled_addmm_errors_cuda_float32 (__main__.TestSparseCSRCUDA) ... ok (0.031s)
  test_sampled_addmm_errors_cuda_float64 (__main__.TestSparseCSRCUDA) ... ok (0.032s)

@jpvillam-amd
Copy link
Copy Markdown
Contributor Author

jpvillam-amd commented Jun 10, 2022

From https://github.com/pytorch/pytorch/runs/6819237934?check_suite_focus=true#step:7:48965 :

  test_sparse_add_cuda_complex128 (__main__.TestSparseCSRCUDA) ... ok (0.039s)
  test_sparse_add_cuda_complex64 (__main__.TestSparseCSRCUDA) ... ok (0.037s)

@pruthvistony
Copy link
Copy Markdown
Collaborator

pruthvistony commented Jun 12, 2022

@malfet
Can you please review this.

@jpvillam-amd
[ROCM] Enable some sparse tests on ROCM
d7a1d5e 
Enabling:
test_sampled_addmm_errors_cuda_complex128
test_sampled_addmm_errors_cuda_complex64
test_sampled_addmm_errors_cuda_float32
test_sampled_addmm_errors_cuda_float64
test_sparse_add_cuda_complex128
test_sparse_add_cuda_complex64
@jpvillam-amd
[ROCm] Missed secondary skip check
ab912be
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Jun 14, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 14, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 14, 2022

Hey @jpvillam-amd.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 16, 2022
@jpvillam-amd @facebook-github-bot
[ROCm] Enable some sparse tests on ROCm (#77877) (#77877)
c4c0760 
Summary:
Enabling:
test_sampled_addmm_errors_cuda_complex128
test_sampled_addmm_errors_cuda_complex64
test_sampled_addmm_errors_cuda_float32
test_sampled_addmm_errors_cuda_float64
test_sparse_add_cuda_complex128
test_sparse_add_cuda_complex64

Pull Request resolved: #77877
Approved by: https://github.com/pruthvistony, https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/aff7eef4764e5478c92e48be8d52f3e75e0ba705

Reviewed By: malfet

Differential Revision: D37156989

fbshipit-source-id: 9e4754ea0287f67c02d16f36093d3c00b2305148
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@jpvillam-amd @pytorchmergebot
[ROCm] Enable some sparse tests on ROCm (pytorch#77877)
2deebbd 
Enabling:
test_sampled_addmm_errors_cuda_complex128
test_sampled_addmm_errors_cuda_complex64
test_sampled_addmm_errors_cuda_float32
test_sampled_addmm_errors_cuda_float64
test_sparse_add_cuda_complex128
test_sparse_add_cuda_complex64

Pull Request resolved: pytorch#77877
Approved by: https://github.com/pruthvistony, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@pruthvistony pruthvistony pruthvistony approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@IvanYashchuk IvanYashchuk Awaiting requested review from IvanYashchuk

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged module: rocm AMD GPU support for Pytorch open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jpvillam-amd @facebook-github-bot @pruthvistony @malfet @pytorchmergebot @pytorchbot @ejguan