Skip to content

Add slow path for device#77684

Closed
eellison wants to merge 7 commits intogh/eellison/291/basefrom
gh/eellison/291/head
Closed

Add slow path for device#77684
eellison wants to merge 7 commits intogh/eellison/291/basefrom
gh/eellison/291/head

Conversation

@eellison
Copy link
Contributor

@eellison eellison commented May 17, 2022

Stack from ghstack (oldest at bottom):

Similar to #77396, add a way to override device on Tensor Subclasses by adding a bit to call into a custom, virtual device function. This is necessary to allow extending devices with a meta device to also carry along a device so as to compute device propagation in addition to other properties (FakeTensors).

Differential Revision: D36618465

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 17, 2022

🔗 Helpful links

✅ No Failures (5 Pending)

As of commit 591c488 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@eellison eellison requested a review from ezyang May 18, 2022 01:20
Similar to #77396, add a way to override `device` on Tensor Subclasses by adding a bit to call into a custom, virtual `device` function. This is necessary to allow extending devices with a `meta` device to also carry along a device so as to compute device propagation in addition to other properties (FakeTensors).

[ghstack-poisoned]
eellison pushed a commit that referenced this pull request May 18, 2022
ghstack-source-id: dfe40b3
Pull Request resolved: #77684
Similar to #77396, add a way to override `device` on Tensor Subclasses by adding a bit to call into a custom, virtual `device` function. This is necessary to allow extending devices with a `meta` device to also carry along a device so as to compute device propagation in addition to other properties (FakeTensors).

[ghstack-poisoned]
Similar to #77396, add a way to override `device` on Tensor Subclasses by adding a bit to call into a custom, virtual `device` function. This is necessary to allow extending devices with a `meta` device to also carry along a device so as to compute device propagation in addition to other properties (FakeTensors).

[ghstack-poisoned]
Similar to #77396, add a way to override `device` on Tensor Subclasses by adding a bit to call into a custom, virtual `device` function. This is necessary to allow extending devices with a `meta` device to also carry along a device so as to compute device propagation in addition to other properties (FakeTensors).

[ghstack-poisoned]
@eellison
Copy link
Contributor Author

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Similar to #77396, add a way to override `device` on Tensor Subclasses by adding a bit to call into a custom, virtual `device` function. This is necessary to allow extending devices with a `meta` device to also carry along a device so as to compute device propagation in addition to other properties (FakeTensors).

Differential Revision: [D36618465](https://our.internmc.facebook.com/intern/diff/D36618465)

[ghstack-poisoned]
@eellison
Copy link
Contributor Author

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

facebook-github-bot pushed a commit that referenced this pull request May 24, 2022
Summary:
Pull Request resolved: #77684

Similar to #77396, add a way to override `device` on Tensor Subclasses by adding a bit to call into a custom, virtual `device` function. This is necessary to allow extending devices with a `meta` device to also carry along a device so as to compute device propagation in addition to other properties (FakeTensors).

Test Plan: Imported from OSS

Reviewed By: Chillee

Differential Revision: D36618465

Pulled By: eellison

fbshipit-source-id: b9dcf480b9e78cbe46c776f1244e7259d871b379
@github-actions
Copy link
Contributor

Hey @eellison.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/eellison/291/head branch May 28, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants