Skip to content

[quant][core][better-engineering] Rename files in quantized/cpu directory to conform with non-quantized countertpart filenames#77422

Closed
dzdang wants to merge 10 commits intogh/dzdang/113/basefrom
gh/dzdang/113/head
Closed

[quant][core][better-engineering] Rename files in quantized/cpu directory to conform with non-quantized countertpart filenames#77422
dzdang wants to merge 10 commits intogh/dzdang/113/basefrom
gh/dzdang/113/head

Conversation

@dzdang
Copy link
Contributor

@dzdang dzdang commented May 13, 2022

Stack from ghstack (oldest at bottom):

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with import torch at runtime. See
#77037 for additional details

Test Plan:

python test/test_quantization.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D36378484

… to conform with non-quantized countertpart filenames

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 13, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit f085d3d (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 13, 2022
…d directory to conform with non-quantized countertpart filenames"

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
…d directory to conform with non-quantized countertpart filenames"

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@dzdang
Copy link
Contributor Author

dzdang commented May 13, 2022

@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…d directory to conform with non-quantized countertpart filenames"

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D36378484](https://our.internmc.facebook.com/intern/diff/D36378484)

[ghstack-poisoned]
dzdang added a commit that referenced this pull request May 13, 2022
… to conform with non-quantized countertpart filenames

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ef9314e
Pull Request resolved: #77422
@dzdang
Copy link
Contributor Author

dzdang commented May 13, 2022

@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…d directory to conform with non-quantized countertpart filenames"

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D36378484](https://our.internmc.facebook.com/intern/diff/D36378484)

[ghstack-poisoned]
@dzdang
Copy link
Contributor Author

dzdang commented May 13, 2022

@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dzdang dzdang added better-engineering Relatively self-contained tasks for better engineering contributors release notes: quantization release notes category labels May 13, 2022
…d directory to conform with non-quantized countertpart filenames"

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D36378484](https://our.internmc.facebook.com/intern/diff/D36378484)

[ghstack-poisoned]
@dzdang
Copy link
Contributor Author

dzdang commented May 13, 2022

@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dzdang dzdang changed the title [quant][core][better-engineering] Rename files in quantized directory to conform with non-quantized countertpart filenames [quant][core][better-engineering] Rename files in quantized/cpu directory to conform with non-quantized countertpart filenames May 13, 2022
…d/cpu directory to conform with non-quantized countertpart filenames"

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D36378484](https://our.internmc.facebook.com/intern/diff/D36378484)

[ghstack-poisoned]
dzdang added a commit that referenced this pull request May 13, 2022
…tory to conform with non-quantized countertpart filenames

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: a6b7d05
Pull Request resolved: #77422
@dzdang
Copy link
Contributor Author

dzdang commented May 13, 2022

@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link

@nickchef nickchef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat change, love hump naming

…d/cpu directory to conform with non-quantized countertpart filenames"

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D36378484](https://our.internmc.facebook.com/intern/diff/D36378484)

[ghstack-poisoned]
dzdang added a commit that referenced this pull request May 24, 2022
…tory to conform with non-quantized countertpart filenames

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e5b0e37
Pull Request resolved: #77422
@dzdang
Copy link
Contributor Author

dzdang commented May 24, 2022

@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…d/cpu directory to conform with non-quantized countertpart filenames"

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D36378484](https://our.internmc.facebook.com/intern/diff/D36378484)

[ghstack-poisoned]
dzdang added a commit that referenced this pull request May 25, 2022
…tory to conform with non-quantized countertpart filenames

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 8411a46
Pull Request resolved: #77422
@dzdang
Copy link
Contributor Author

dzdang commented May 25, 2022

@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…d/cpu directory to conform with non-quantized countertpart filenames"

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D36378484](https://our.internmc.facebook.com/intern/diff/D36378484)

[ghstack-poisoned]
dzdang added a commit that referenced this pull request May 31, 2022
…tory to conform with non-quantized countertpart filenames

Summary:
Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: f5a6917
Pull Request resolved: #77422
@dzdang
Copy link
Contributor Author

dzdang commented May 31, 2022

@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Hey @dzdang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 1, 2022
…tory to conform with non-quantized countertpart filenames (#77422)

Summary:
Pull Request resolved: #77422

Names of analogous files in quantized directory (previously snake case) were inconsistent with
their non-quantized filename counterparts (pascal case). This is the second of a series of PRs that changes
all files in quantized (and sub-directories) dir to have pascal case.

Some files have not been renamed as it is causing issues related to
custom class with `import torch` at runtime. See
#77037 for additional details

Test Plan:
```
python test/test_quantization.py
```

```
python test/test_quantization.py
```

Imported from OSS

Differential Revision:
D36378484
D36378484

Reviewed By: jerryzh168

Pulled By: dzdang

fbshipit-source-id: bfa25fec4ee618d490fc41a34b9b6e51f41be4e4
@dzdang dzdang added the topic: improvements topic category label Jun 1, 2022
@facebook-github-bot facebook-github-bot deleted the gh/dzdang/113/head branch June 5, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

better-engineering Relatively self-contained tasks for better engineering contributors cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue release notes: quantization release notes category topic: improvements topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants