stft: remove non-center overload and python functional wrapper#77257
Closed
peterbell10 wants to merge 1 commit intogh/peterbell10/322/basefrom
Closed
stft: remove non-center overload and python functional wrapper#77257peterbell10 wants to merge 1 commit intogh/peterbell10/322/basefrom
peterbell10 wants to merge 1 commit intogh/peterbell10/322/basefrom
Conversation
This brings the C++ API of stft into sync with the python API, and adds the required upgraders to ensure backward compatibility for TorchScript models. [ghstack-poisoned]
Contributor
🔗 Helpful links
❌ 9 New FailuresAs of commit 5e69452 (more details on the Dr. CI page): Expand to see more
🕵️ 9 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
peterbell10
commented
May 11, 2022
| self.assertEqual(output, output_expected) | ||
|
|
||
| def test_versioned_stft_v10(self): | ||
| model_path = pytorch_test_dir + "/jit/fixtures/test_versioned_stft_v10.ptl" |
Collaborator
Author
There was a problem hiding this comment.
These upgrader tests using .ptl models pass fine, but non-lite models don't work at all as reported in #73434 (comment)
Are my upgraders just configured incorrectly, or do upgraders only work with the lite interpreter?
Collaborator
Author
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Contributor
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This brings the C++ API of stft into sync with the python API, and
adds the required upgraders to ensure backward compatibility for
TorchScript models.