Skip to content

Support Tensor source for x.set_(storage, offset, size, strides)#77007

Closed
ezyang wants to merge 1 commit intogh/ezyang/1145/basefrom
gh/ezyang/1145/head
Closed

Support Tensor source for x.set_(storage, offset, size, strides)#77007
ezyang wants to merge 1 commit intogh/ezyang/1145/basefrom
gh/ezyang/1145/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented May 6, 2022 •
edited
Loading

Stack from ghstack:

This is convenient for cases where we don't have Storage bound
correctly (e.g., meta tensors). It is also consistent with a universe
where we get rid of storages, although arguably this is never
gonna happen.

Signed-off-by: Edward Z. Yang ezyang@fb.com

@ezyang
Support Tensor source for x.set_(storage, offset, size, strides)
c174dbe 
This is convenient for cases where we don't have Storage bound
correctly (e.g., meta tensors).  It is also consistent with a universe
where we get rid of storages, although arguably this is never
gonna happen.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 6, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit c174dbe (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ezyang ezyang mentioned this pull request May 6, 2022
Closed
@ezyang
Copy link
Contributor Author

ezyang commented May 7, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1145/head branch May 10, 2022 14:16
facebook-github-bot pushed a commit that referenced this pull request May 13, 2022
@ezyang @facebook-github-bot
Support Tensor source for x.set_(storage, offset, size, strides) (#77007
0ca6887 
)

Summary:
This is convenient for cases where we don't have Storage bound
correctly (e.g., meta tensors).  It is also consistent with a universe
where we get rid of storages, although arguably this is never
gonna happen.

Signed-off-by: Edward Z. Yang <ezyangfb.com>

Pull Request resolved: #77007

Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e3dcd175f7aacb6aa2fb150b01335afd508c9d52

Reviewed By: malfet

Differential Revision: D36250486

fbshipit-source-id: ccc70c69df10fe915a185a0cb365a48944033a0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @facebook-github-bot @ngimel @pytorchmergebot