[quant][core][gpu][improvement] Made plan and run for quantized cudnn conv op conform with Conv_v8.cpp#76788
Closed
dzdang wants to merge 5 commits intogh/dzdang/105/basefrom
Closed
[quant][core][gpu][improvement] Made plan and run for quantized cudnn conv op conform with Conv_v8.cpp#76788dzdang wants to merge 5 commits intogh/dzdang/105/basefrom
dzdang wants to merge 5 commits intogh/dzdang/105/basefrom
Conversation
…8.cpp Summary: The workspace and plan in Conv_v8.cpp diverged from Conv.cpp after #60755 landed. This PR conforms the two files in regards to the workspace and plan. Test Plan: ``` python test/test_quantization.py -k test_qconv2d_cudnn ``` [ghstack-poisoned]
This was referenced May 4, 2022
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 186ba01 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
approved these changes
May 10, 2022
Contributor
jerryzh168
left a comment
There was a problem hiding this comment.
probably want to make the same changes to other ops as well if they are not already aligned
…with Conv_v8.cpp" Summary: The workspace and plan in Conv_v8.cpp diverged from Conv.cpp after #60755 landed. This PR conforms the two files in regards to the workspace and plan. Test Plan: ``` python test/test_quantization.py -k test_qconv2d_cudnn ``` Differential Revision: [D36121582](https://our.internmc.facebook.com/intern/diff/D36121582) [ghstack-poisoned]
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
dzdang
added a commit
that referenced
this pull request
May 16, 2022
…r op conform with Conv_v8.cpp Summary: See #76788 summary. Same idea applies here but for the linear operator Test Plan: ``` python test/test_quantization.py -k test_qlinear_cudnn ``` [ghstack-poisoned]
…tized cudnn conv op conform with Conv_v8.cpp" Summary: The workspace and plan in Conv_v8.cpp diverged from Conv.cpp after #60755 landed. This PR conforms the two files in regards to the workspace and plan. Test Plan: ``` python test/test_quantization.py -k test_qconv2d_cudnn ``` Differential Revision: [D36121582](https://our.internmc.facebook.com/intern/diff/D36121582) [ghstack-poisoned]
dzdang
added a commit
that referenced
this pull request
May 16, 2022
… conv op conform with Conv_v8.cpp Summary: The workspace and plan in Conv_v8.cpp diverged from Conv.cpp after #60755 landed. This PR conforms the two files in regards to the workspace and plan. Test Plan: ``` python test/test_quantization.py -k test_qconv2d_cudnn ``` ghstack-source-id: 6ba2b1d Pull Request resolved: #76788
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…tized cudnn conv op conform with Conv_v8.cpp" Summary: The workspace and plan in Conv_v8.cpp diverged from Conv.cpp after #60755 landed. This PR conforms the two files in regards to the workspace and plan. Test Plan: ``` python test/test_quantization.py -k test_qconv2d_cudnn ``` Differential Revision: [D36121582](https://our.internmc.facebook.com/intern/diff/D36121582) [ghstack-poisoned]
…tized cudnn conv op conform with Conv_v8.cpp" Summary: The workspace and plan in Conv_v8.cpp diverged from Conv.cpp after #60755 landed. This PR conforms the two files in regards to the workspace and plan. Test Plan: ``` python test/test_quantization.py -k test_qconv2d_cudnn ``` Differential Revision: [D36121582](https://our.internmc.facebook.com/intern/diff/D36121582) [ghstack-poisoned]
dzdang
added a commit
that referenced
this pull request
May 24, 2022
… conv op conform with Conv_v8.cpp Summary: The workspace and plan in Conv_v8.cpp diverged from Conv.cpp after #60755 landed. This PR conforms the two files in regards to the workspace and plan. Test Plan: ``` python test/test_quantization.py -k test_qconv2d_cudnn ``` ghstack-source-id: 141c0db Pull Request resolved: #76788
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 25, 2022
… conv op conform with Conv_v8.cpp (#76788) Summary: Pull Request resolved: #76788 The workspace and plan in Conv_v8.cpp diverged from Conv.cpp after #60755 landed. This PR conforms the two files in regards to the workspace and plan. Test Plan: ``` python test/test_quantization.py -k test_qconv2d_cudnn ``` ``` python test/test_quantization.py -k test_qconv2d_cudnn ``` Differential Revision: D36121582 D36121582 Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 4d23817a7603cc36af47911d8543b92bdcc26617
pytorchmergebot
pushed a commit
that referenced
this pull request
May 25, 2022
…r op conform with Conv_v8.cpp Summary: See #76788 summary. Same idea applies here but for the linear operator Test Plan: ``` python test/test_quantization.py -k test_qlinear_cudnn ``` Pull Request resolved: #77519 Approved by: https://github.com/jerryzh168
facebook-github-bot
pushed a commit
that referenced
this pull request
May 25, 2022
…r op conform with Conv_v8.cpp (#77519) Summary: Pull Request resolved: #77519 See #76788 summary. Same idea applies here but for the linear operator Test Plan: ``` python test/test_quantization.py -k test_qlinear_cudnn ``` Reviewed By: jerryzh168 Differential Revision: D36403831 Pulled By: dzdang fbshipit-source-id: 971590efbed4340d12e5b9e420c86e8ad5c25008
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
The workspace and plan in Conv_v8.cpp diverged from Conv.cpp after
#60755 landed. This PR conforms
the two files in regards to the workspace and plan.
Test Plan:
Differential Revision: D36121582