Skip to content

increase sleep for TestCuda.test_caching_pinned_memory_multi_gpu#76601

Closed
jeffdaily wants to merge 1 commit intopytorch:masterfrom
ROCm:rocm_increase_test_caching_pinned_timeout
Closed

increase sleep for TestCuda.test_caching_pinned_memory_multi_gpu#76601
jeffdaily wants to merge 1 commit intopytorch:masterfrom
ROCm:rocm_increase_test_caching_pinned_timeout

Conversation

@jeffdaily
Copy link
Copy Markdown
Collaborator

@jeffdaily jeffdaily commented Apr 29, 2022

Fixes #68299. Fixes #70875.

Test is flaky on ROCm because the HIP runtime occasionally copies asynchronously too quickly for the current sleep value of 50ms. This is not a bug. Increasing the sleep value to 1s to avoid flakiness.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 29, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 9abb3d3 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@dagitses dagitses requested review from dagitses and ngimel and removed request for dagitses May 2, 2022 11:28
@dagitses dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 2, 2022
malfet
malfet approved these changes Jun 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this will increase test time by 2 sec, which is fine, but might be reason for revert if it start affecting other tests.
cc: @janeyx99

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Jun 14, 2022

@pytorchbot merge -f

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 14, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 14, 2022

Hey @jeffdaily.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 16, 2022
@jeffdaily @facebook-github-bot
increase sleep for TestCuda.test_caching_pinned_memory_multi_gpu (#76601
732b610 
) (#76601)

Summary:
Fixes #68299.  Fixes #70875.

Test is flaky on ROCm because the HIP runtime occasionally copies asynchronously too quickly for the current sleep value of 50ms.  This is not a bug.  Increasing the sleep value to 1s to avoid flakiness.

Pull Request resolved: #76601
Approved by: https://github.com/pruthvistony, https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/20d56d2b3295c909fcc1e8648124b0b509cea1ca

Reviewed By: malfet

Differential Revision: D37156969

fbshipit-source-id: b7808c46a9327740629a349c8f2d71717f28805b
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@jeffdaily @pytorchmergebot
increase sleep for TestCuda.test_caching_pinned_memory_multi_gpu (pyt…
3c2d24b 
…orch#76601)

Fixes pytorch#68299.  Fixes pytorch#70875.

Test is flaky on ROCm because the HIP runtime occasionally copies asynchronously too quickly for the current sleep value of 50ms.  This is not a bug.  Increasing the sleep value to 1s to avoid flakiness.
Pull Request resolved: pytorch#76601
Approved by: https://github.com/pruthvistony, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@pruthvistony pruthvistony pruthvistony approved these changes

@ngimel ngimel Awaiting requested review from ngimel

Assignees

@ngimel ngimel

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

8 participants

@jeffdaily @facebook-github-bot @malfet @pytorchmergebot @pruthvistony @dagitses @ngimel @pytorchbot