[DataPipe] clearing buffer for DataPipes during __del__#76345
Closed
NivekT wants to merge 1 commit intogh/nivekt/50/basefrom
Closed
[DataPipe] clearing buffer for DataPipes during __del__#76345NivekT wants to merge 1 commit intogh/nivekt/50/basefrom
NivekT wants to merge 1 commit intogh/nivekt/50/basefrom
Conversation
[ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 25cf3e9 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
Author
|
@pytorchbot merge this please |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
Summary: Pull Request resolved: #76345 Approved by: https://github.com/ejguan Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/ccd7233fdd4322723ec4bf8446ff853f14d384da Reviewed By: osalpekar Differential Revision: D35938177 Pulled By: NivekT fbshipit-source-id: 9c19f9a5069d9be98fcc6902f9cef45f81ed697c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes meta-pytorch/data#370
Edit: I checked the DataPipes in TorchData. The only one that uses a buffer is
UnZipperbut it is inherited fromForker. Therefore, that buffer will be cleared by the change in this PR as well.