Skip to content

Revert "[nnc] Strides to Tensor (#72962)"#76332

Closed
zengk95 wants to merge 1 commit intomasterfrom
revert-nnc-strides
Closed

Revert "[nnc] Strides to Tensor (#72962)"#76332
zengk95 wants to merge 1 commit intomasterfrom
revert-nnc-strides

Conversation

@zengk95
Copy link
Contributor

@zengk95 zengk95 commented Apr 25, 2022

This reverts commit 9390609.

Fixes pytorch/vision#5873

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 25, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 816e0e5 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Apr 25, 2022
@zengk95
Copy link
Contributor Author

zengk95 commented Apr 25, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2022

Hey @zengk95.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
@zengk95 @facebook-github-bot
Revert "[nnc] Strides to Tensor (#72962)" (#76332)
04d2480 
Summary:
This reverts commit 9390609.

Fixes pytorch/vision#5873

Pull Request resolved: #76332
Approved by: https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/1d55518198de14a011e7acd6c604afe512ee28b4

Reviewed By: osalpekar

Differential Revision: D35938180

Pulled By: zengk95

fbshipit-source-id: 15f48235b3b11ce9ca2379781f9e75cd1af39aed
@zengk95 zengk95 deleted the revert-nnc-strides branch July 6, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@datumbox datumbox Awaiting requested review from datumbox

@IvanKobzarev IvanKobzarev Awaiting requested review from IvanKobzarev

@janeyx99 janeyx99 Awaiting requested review from janeyx99

Assignees

No one assigned

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI jobs broken due to upstream changes on padding and stride

3 participants

@zengk95 @facebook-github-bot @seemethere