Skip to content

Remove incorrect xfail#76268

Closed
peterbell10 wants to merge 1 commit intopytorch:masterfrom
peterbell10:fx-xfail-fixup
Closed

Remove incorrect xfail#76268
peterbell10 wants to merge 1 commit intopytorch:masterfrom
peterbell10:fx-xfail-fixup

Conversation

@peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Apr 23, 2022

This xfail'ed test was fixed by #75896 but didn't show up in CI because it's a slow test.

@peterbell10 peterbell10 added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 23, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 23, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit c26ccce (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ngimel
Copy link
Collaborator

ngimel commented Apr 23, 2022

@pytorchbot merge this please

@ngimel
Copy link
Collaborator

ngimel commented Apr 23, 2022

@pytorchbot merge this please

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 23, 2022

Can't merge closed PR #76268

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2022

Hey @peterbell10.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@peterbell10 peterbell10 added the topic: not user facing topic category label Apr 23, 2022
@peterbell10 peterbell10 mentioned this pull request Apr 23, 2022
Closed
facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
@peterbell10 @facebook-github-bot
Remove incorrect xfail (#76268)
aedca09 
Summary:
This xfail'ed test was fixed by #75896 but didn't show up in CI because it's a slow test.

Pull Request resolved: #76268
Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/1a7e43be141ce01469d7605075cb1008bf19abd7

Reviewed By: seemethere, osalpekar

Differential Revision: D35874478

fbshipit-source-id: 5f5a8e4cf665fea273017691ff8d15c973178771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

@mruberry mruberry Awaiting requested review from mruberry

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peterbell10 @facebook-github-bot @ngimel @pytorchmergebot @pytorchbot