Closed
Conversation
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit cff29d0 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
albanD
reviewed
Apr 20, 2022
Collaborator
albanD
left a comment
There was a problem hiding this comment.
Thanks for taking the time to do this! It looks great!
Contributor
Author
I need to land this PR internally from phabricator because the changes need to be made in a single Diff to be shipped to both PyTorch and TorchData together. |
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
anjali411
approved these changes
Apr 20, 2022
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
reviewed
Apr 21, 2022
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Apr 21, 2022
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Apr 21, 2022
Summary: This is PR aims to expose the right data-relate API. There are two more changes made in this PR to convert public api to private api `check_lambda_fn` -> `_check_lambda_fn` `deprecation_warning` -> `_deprecation_warning` X-link: pytorch/pytorch#76143 Reviewed By: albanD, NivekT Differential Revision: D35798311 Pulled By: ejguan fbshipit-source-id: 16898c8828dae42afa0b84660f8961005d419c6f
facebook-github-bot
pushed a commit
to meta-pytorch/data
that referenced
this pull request
Apr 21, 2022
Summary: Pull Request resolved: #368 This is PR aims to expose the right data-relate API. There are two more changes made in this PR to convert public api to private api `check_lambda_fn` -> `_check_lambda_fn` `deprecation_warning` -> `_deprecation_warning` X-link: pytorch/pytorch#76143 Reviewed By: albanD, NivekT Differential Revision: D35798311 Pulled By: ejguan fbshipit-source-id: b13fded5c88a533c706702fb2070c918c839dca4
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 21, 2022
Summary: X-link: meta-pytorch/data#368 This is PR aims to expose the right data-relate API. There are two more changes made in this PR to convert public api to private api `check_lambda_fn` -> `_check_lambda_fn` `deprecation_warning` -> `_deprecation_warning` Pull Request resolved: #76143 Reviewed By: albanD, NivekT Differential Revision: D35798311 Pulled By: ejguan fbshipit-source-id: b13fded5c88a533c706702fb2070c918c839dca4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR aims to expose the right data-relate API.
There are two more changes made in this PR to convert public api to private api
check_lambda_fn->_check_lambda_fndeprecation_warning->_deprecation_warning