Fix: memory cross-border access on the ROCM platform by visualxu · Pull Request #76100 · pytorch/pytorch

visualxu · 2022-04-20T10:40:34Z

Fixes #76095, memory cross-border access on the ROCM platform.

facebook-github-bot · 2022-04-20T10:40:38Z

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot · 2022-04-20T10:40:40Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/76100
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit 5f36deb (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot · 2022-04-20T15:25:27Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot · 2022-04-20T15:25:31Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

jeffdaily

LGTM. CI passing, as well.

kit1980 · 2022-06-17T00:35:12Z

@pytorchbot rebase

kit1980 · 2022-06-17T00:35:37Z

@visualxu @jeffdaily is this something we still want to merge?

pytorchmergebot · 2022-06-17T00:36:38Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-06-17T00:36:43Z

Successfully rebased rocm_iluvatar onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout rocm_iluvatar && git pull --rebase)

jeffdaily · 2022-06-20T15:42:36Z

@visualxu @jeffdaily is this something we still want to merge?

Yes. The explanation and fix seem reasonable to me. It wasn't clear to me how this issue was discovered, but shouldn't we fix things that are proven to be broken, even if they are perhaps rare cases?

CI was passing previously. For sanity, I kicked off rocm CI again (because rocm jobs moved to trunk-only, needed manual start for this PR).

jeffdaily · 2022-06-21T19:16:17Z

CI has passed for ROCm. 2 failures for ios-12-5-1 are not related.

jeffdaily · 2022-07-25T16:53:56Z

@pytorchbot rebase

pytorch-bot · 2022-07-25T16:53:58Z

You don't have permissions to rebase this PR, only the PR author and pytorch organization members may rebase this PR.

jeffdaily · 2022-07-25T16:54:10Z

After the latest rebase can we get this merged?

pytorchmergebot · 2022-07-28T14:34:55Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-07-28T14:34:57Z

Merge failed due to This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again.
Raised by https://github.com/pytorch/pytorch/actions/runs/2754541563

visualxu · 2022-07-28T14:36:45Z

@pytorchbot merge

pytorchmergebot · 2022-07-28T14:39:30Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-07-28T14:39:31Z

Merge failed due to This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again.
Raised by https://github.com/pytorch/pytorch/actions/runs/2754570892

visualxu · 2022-07-28T14:40:42Z

@pytorchbot rebase

pytorchmergebot · 2022-07-28T14:42:22Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-07-28T14:42:26Z

Successfully rebased rocm_iluvatar onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout rocm_iluvatar && git pull --rebase)

visualxu · 2022-07-28T14:45:32Z

@pytorchbot merge

pytorchmergebot · 2022-07-28T14:47:20Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-07-28T14:47:24Z

Merge failed due to Matched rule superuser, but PR #76100 was not reviewed yet by any of: suo, Nitrokitty, hanton, bochko, alexanderguzhva, ...
Raised by https://github.com/pytorch/pytorch/actions/runs/2754624499

jithunnair-amd · 2022-08-01T22:27:55Z

@kit1980 We need someone from PyTorch team to approve this PR

jeffdaily · 2022-08-01T23:21:41Z

@pytorchbot merge

pytorchmergebot · 2022-08-01T23:22:54Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-08-01T23:22:55Z

Merge failed due to This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again.
Raised by https://github.com/pytorch/pytorch/actions/runs/2778534216

jeffdaily · 2022-08-01T23:27:28Z

@pytorchbot rebase

pytorch-bot · 2022-08-01T23:27:30Z

You don't have permissions to rebase this PR, only the PR author and pytorch organization members may rebase this PR.

jeffdaily · 2022-08-01T23:28:09Z

@kit1980 thanks for the approval, can you also trigger a rebase? I only have permission to merge.

kit1980 · 2022-08-01T23:29:35Z

@pytorchbot rebase

pytorchmergebot · 2022-08-01T23:30:59Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-08-01T23:31:03Z

Successfully rebased rocm_iluvatar onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout rocm_iluvatar && git pull --rebase)

jeffdaily · 2022-08-01T23:34:58Z

@pytorchbot merge

pytorchmergebot · 2022-08-01T23:36:17Z

@pytorchbot successfully started a merge job. Check the current status here

github-actions · 2022-08-02T02:47:52Z

Hey @visualxu.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Fixes #76095, memory cross-border access on the ROCM platform. Pull Request resolved: #76100 Approved by: https://github.com/jeffdaily, https://github.com/kit1980 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/62de55ed6b58275f9e7899aab89910818254e0b6 Reviewed By: kit1980 Differential Revision: D38359417 fbshipit-source-id: 134f261e18cb766ad1e5cb6edf175ba3c6731c50

pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Apr 20, 2022

pytorchbot added the open source label Apr 20, 2022

facebook-github-bot added the cla signed label Apr 20, 2022

jeffdaily approved these changes Apr 20, 2022

View reviewed changes

pytorchmergebot force-pushed the rocm_iluvatar branch from 49a0501 to 5a926aa Compare June 17, 2022 00:36

jeffdaily added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 20, 2022

pytorchmergebot force-pushed the rocm_iluvatar branch from 5a926aa to 52bdfb9 Compare July 28, 2022 14:42

kit1980 approved these changes Aug 1, 2022

View reviewed changes

Fix: memory cross-border access on the ROCM platform

5f36deb

pytorchmergebot force-pushed the rocm_iluvatar branch from 52bdfb9 to 5f36deb Compare August 1, 2022 23:31

pytorchmergebot added the Merged label Aug 2, 2022

pytorchmergebot closed this in 62de55e Aug 2, 2022

Conversation

visualxu commented Apr 20, 2022 • edited by jeffdaily Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 20, 2022

Action Required

Process

Uh oh!

facebook-github-bot commented Apr 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

facebook-github-bot commented Apr 20, 2022

Uh oh!

facebook-github-bot commented Apr 20, 2022

Uh oh!

jeffdaily left a comment

Choose a reason for hiding this comment

Uh oh!

kit1980 commented Jun 17, 2022

Uh oh!

kit1980 commented Jun 17, 2022

Uh oh!

pytorchmergebot commented Jun 17, 2022

Uh oh!

pytorchmergebot commented Jun 17, 2022

Uh oh!

jeffdaily commented Jun 20, 2022

Uh oh!

jeffdaily commented Jun 21, 2022

Uh oh!

jeffdaily commented Jul 25, 2022

Uh oh!

pytorch-bot bot commented Jul 25, 2022

Uh oh!

jeffdaily commented Jul 25, 2022

Uh oh!

pytorchmergebot commented Jul 28, 2022

Uh oh!

pytorchmergebot commented Jul 28, 2022

Uh oh!

visualxu commented Jul 28, 2022

Uh oh!

pytorchmergebot commented Jul 28, 2022

Uh oh!

pytorchmergebot commented Jul 28, 2022

Uh oh!

visualxu commented Jul 28, 2022

Uh oh!

pytorchmergebot commented Jul 28, 2022

Uh oh!

pytorchmergebot commented Jul 28, 2022

Uh oh!

visualxu commented Jul 28, 2022

Uh oh!

pytorchmergebot commented Jul 28, 2022

Uh oh!

pytorchmergebot commented Jul 28, 2022

Uh oh!

jithunnair-amd commented Aug 1, 2022

Uh oh!

jeffdaily commented Aug 1, 2022

Uh oh!

pytorchmergebot commented Aug 1, 2022

Uh oh!

pytorchmergebot commented Aug 1, 2022

Uh oh!

jeffdaily commented Aug 1, 2022

Uh oh!

pytorch-bot bot commented Aug 1, 2022

Uh oh!

jeffdaily commented Aug 1, 2022

Uh oh!

kit1980 commented Aug 1, 2022

Uh oh!

pytorchmergebot commented Aug 1, 2022

Uh oh!

pytorchmergebot commented Aug 1, 2022

Uh oh!

visualxu commented Apr 20, 2022 •

edited by jeffdaily

Loading

facebook-github-bot commented Apr 20, 2022 •

edited

Loading