Skip to content

fix out= op handling for functionalization#75818

Closed
bdhirsh wants to merge 6 commits intogh/bdhirsh/205/basefrom
gh/bdhirsh/205/head
Closed

fix out= op handling for functionalization#75818
bdhirsh wants to merge 6 commits intogh/bdhirsh/205/basefrom
gh/bdhirsh/205/head

Conversation

@bdhirsh
Copy link
Collaborator

@bdhirsh bdhirsh commented Apr 14, 2022 •
edited
Loading

Before, we weren't actually propagating the updates from the out= tensors back into the functional wrappers. cc @ZolotukhinM. I also added some more complicated tests for this in functorch here: https://github.com/pytorch/functorch/pull/678/files#diff-449582f4f3e1ae76a73397c4b8ca62cc9dd5235dd831187f143180b498dee332R2896

Stack from ghstack:

Differential Revision: D35705377

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 14, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 7d744bc (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Apr 14, 2022
Closed
Closed
Closed
Closed
Closed
Merged
@bdhirsh bdhirsh requested review from albanD and ezyang April 14, 2022 20:59
@bdhirsh
Update on "fix out= op handling for functionalization"
6a6735a 
Before, we weren't actually propagating the updates from the out= tensors back into the functional wrappers. cc @ZolotukhinM. I also added some more complicated tests for this in functorch here: https://github.com/pytorch/functorch/pull/678/files#diff-449582f4f3e1ae76a73397c4b8ca62cc9dd5235dd831187f143180b498dee332R2896




[ghstack-poisoned]
@bdhirsh bdhirsh mentioned this pull request Apr 15, 2022
Closed
bdhirsh added 2 commits April 15, 2022 15:26
@bdhirsh
Update on "fix out= op handling for functionalization"
cf52a75 
Before, we weren't actually propagating the updates from the out= tensors back into the functional wrappers. cc @ZolotukhinM. I also added some more complicated tests for this in functorch here: https://github.com/pytorch/functorch/pull/678/files#diff-449582f4f3e1ae76a73397c4b8ca62cc9dd5235dd831187f143180b498dee332R2896




[ghstack-poisoned]
@bdhirsh
Update on "fix out= op handling for functionalization"
7d744bc 
Before, we weren't actually propagating the updates from the out= tensors back into the functional wrappers. cc @ZolotukhinM. I also added some more complicated tests for this in functorch here: https://github.com/pytorch/functorch/pull/678/files#diff-449582f4f3e1ae76a73397c4b8ca62cc9dd5235dd831187f143180b498dee332R2896




[ghstack-poisoned]
@bdhirsh
Copy link
Collaborator Author

bdhirsh commented Apr 17, 2022

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 18, 2022

@pytorchbot merge this

(Initiating merge automatically since Phabricator Diff has merged)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2022

Hey @bdhirsh.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 18, 2022
@bdhirsh @facebook-github-bot
fix out= op handling for functionalization (#75818)
565f786 
Summary:
Pull Request resolved: #75818

Before, we weren't actually propagating the updates from the out= tensors back into the functional wrappers. cc ZolotukhinM. I also added some more complicated tests for this in functorch here: https://github.com/pytorch/functorch/pull/678/files#diff-449582f4f3e1ae76a73397c4b8ca62cc9dd5235dd831187f143180b498dee332R2896

Test Plan: Imported from OSS

Reviewed By: zhxchen17

Differential Revision: D35705377

Pulled By: bdhirsh

fbshipit-source-id: 51628dc762b62b9a045ae5bae58eeac2ff408178
malfet pushed a commit that referenced this pull request Apr 20, 2022
@bdhirsh @malfet
fix out= op handling for functionalization
ad7aa91 
Pull Request resolved: #75818

Approved by: https://github.com/ezyang

(cherry picked from commit 4c7b4b5)
@facebook-github-bot facebook-github-bot deleted the gh/bdhirsh/205/head branch April 22, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bdhirsh @facebook-github-bot @ezyang