Skip to content

ROCm: Enable test_distributed_spawn#75526

Closed
jaglinux wants to merge 1 commit intopytorch:masterfrom
jaglinux:origin/enable_dist_spawn
Closed

ROCm: Enable test_distributed_spawn#75526
jaglinux wants to merge 1 commit intopytorch:masterfrom
jaglinux:origin/enable_dist_spawn

Conversation

@jaglinux
Copy link
Copy Markdown
Contributor

@jaglinux jaglinux commented Apr 8, 2022

Fixes ROCm#927

Signed-off-by: Jagadish Krishnamoorthy jagdish.krishna@gmail.com

Fixes #927

@jaglinux
ROCm: Enable test_distributed_spawn
e56d7de 
Fixes ROCm#927

Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com>
@pytorch-bot pytorch-bot Bot added the module: rocm AMD GPU support for Pytorch label Apr 8, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 8, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit e56d7de (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build trunk / ios-12-5-1-x86-64 / build (1/1)

Step: "Run Simulator Tests" (full log | diagnosis details | 🔁 rerun)

2022-04-12T16:25:09.3708560Z [!] Tests have failed�[0m 
2022-04-12T16:24:06.9238680Z [16:24:06]: ▸ �[35mLoading...�[0m
2022-04-12T16:25:07.2952260Z [16:25:07]: �[31mExit status: 65�[0m
2022-04-12T16:25:09.3702570Z +--------------------+----+
2022-04-12T16:25:09.3703190Z |      Test Results       |
2022-04-12T16:25:09.3704070Z +--------------------+----+
2022-04-12T16:25:09.3704710Z | Number of tests    | 35 |
2022-04-12T16:25:09.3706030Z | Number of failures | �[31m2�[0m  |
2022-04-12T16:25:09.3706940Z +--------------------+----+
2022-04-12T16:25:09.3707360Z 
2022-04-12T16:25:09.3707780Z �[31m
2022-04-12T16:25:09.3708560Z [!] Tests have failed�[0m
2022-04-12T16:25:09.3995910Z ##[error]Process completed with exit code 1.
2022-04-12T16:25:09.4082560Z Post job cleanup.
2022-04-12T16:25:09.4136070Z Post job cleanup.
2022-04-12T16:25:09.5508070Z [command]/usr/local/bin/git version
2022-04-12T16:25:09.6315030Z git version 2.35.1
2022-04-12T16:25:09.6371580Z [command]/usr/local/bin/git config --local --name-only --get-regexp core\.sshCommand
2022-04-12T16:25:09.6449000Z [command]/usr/local/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2022-04-12T16:25:09.7415810Z Entering 'android/libs/fbjni'
2022-04-12T16:25:09.7584300Z Entering 'third_party/FP16'
2022-04-12T16:25:09.7746290Z Entering 'third_party/FXdiv'
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Apr 8, 2022
@jaglinux
Copy link
Copy Markdown
Contributor Author

jaglinux commented Apr 8, 2022

cc @amathews-amd @arindamroy-eng @pruthvistony

@samdow samdow added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 11, 2022
@jeffdaily jeffdaily added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 12, 2022
mrshenli
mrshenli approved these changes Apr 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pytorchbot merge this please

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 25, 2022

+1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2022

Hey @jaglinux.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
@jaglinux @facebook-github-bot
ROCm: Enable test_distributed_spawn (#75526)
b67f7ed 
Summary:
Fixes ROCm#927

Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com>

Fixes #927

Pull Request resolved: #75526
Approved by: https://github.com/mrshenli

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/81586a6a5ecfdd6056a6a3430fbdd8bc7d1bcf56

Reviewed By: seemethere

Differential Revision: D35903088

Pulled By: seemethere

fbshipit-source-id: cb9c4805799f42faf065ba58c112ff31516980f3
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@jaglinux @pytorchmergebot
ROCm: Enable test_distributed_spawn
47009a9 
Fixes ROCm#927

Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com>

Fixes pytorch#927

Pull Request resolved: pytorch#75526
Approved by: https://github.com/mrshenli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli mrshenli approved these changes

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed module: rocm AMD GPU support for Pytorch oncall: distributed Add this issue/PR to distributed oncall triage queue open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unskip TestDistBackendWithSpawn

6 participants

@jaglinux @facebook-github-bot @mrshenli @jeffdaily @samdow @pytorchbot