move generate_code resources into tools/autograd library#75463
Closed
dagitses wants to merge 19 commits into
Closed
move generate_code resources into tools/autograd library#75463dagitses wants to merge 19 commits into
dagitses wants to merge 19 commits into
Conversation
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1cc5e96 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
dagitses
pushed a commit
that referenced
this pull request
Apr 7, 2022
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! ghstack-source-id: 153348385 Pull Request resolved: #75463
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
added 2 commits
April 7, 2022 17:36
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
added 2 commits
April 7, 2022 17:41
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
added 5 commits
April 12, 2022 09:00
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This was referenced Apr 12, 2022
added 2 commits
April 13, 2022 02:19
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
albanD
reviewed
Apr 13, 2022
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Apr 13, 2022
Pull Request resolved: #75463 This better matches how the corresponding Bazel library does it. ghstack-source-id: 153787721 Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)!
malfet
approved these changes
Apr 13, 2022
Contributor
|
@pytorchbot merge this (Initiating merge automatically since Phabricator Diff has merged) |
Contributor
|
Hey @dagitses. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 14, 2022
Summary: Pull Request resolved: #75463 This better matches how the corresponding Bazel library does it. ghstack-source-id: 153787721 Test Plan: Rely on CI. Reviewed By: malfet, albanD Differential Revision: D35480501 fbshipit-source-id: 5d992cdfe146ca714d14446f4ddd8c43e52b1a96
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Pull Request resolved: pytorch#75463 This better matches how the corresponding Bazel library does it. Differential Revision: [D35480501](https://our.internmc.facebook.com/intern/diff/D35480501/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35480501/)! Approved by: https://github.com/albanD, https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This better matches how the corresponding Bazel library does it.
Differential Revision: D35480501
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!