Skip to content

Reland NVFuser guard changes#75303

Closed
Chillee wants to merge 1 commit intomasterfrom
nvfuser_guard
Closed

Reland NVFuser guard changes#75303
Chillee wants to merge 1 commit intomasterfrom
nvfuser_guard

Conversation

@Chillee
Copy link
Copy Markdown
Collaborator

@Chillee Chillee commented Apr 6, 2022

Reland of #75016 with USE_CUDA => USE_NVFUSER

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 6, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 3e332d7 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Apr 6, 2022
@Chillee Chillee mentioned this pull request Apr 6, 2022
Closed
1 task
jjsjann123
jjsjann123 approved these changes Apr 6, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jjsjann123 jjsjann123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping out~

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 6, 2022

@Chillee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Chillee
Copy link
Copy Markdown
Collaborator Author

Chillee commented Apr 6, 2022

@pytorchbot merge this please

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2022

Hey @Chillee.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@Chillee Chillee added the topic: not user facing topic category label Apr 6, 2022
facebook-github-bot pushed a commit that referenced this pull request Apr 7, 2022
@Chillee @facebook-github-bot
Reland NVFuser guard changes (#75303)
7a121bd 
Summary:
Reland of #75016 with `USE_CUDA` => `USE_NVFUSER`

Pull Request resolved: #75303
Approved by: https://github.com/jjsjann123, https://github.com/davidberard98

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/5994d684840a6b3be37bfa033af92c891ba257a6

Reviewed By: b0noI, davidberard98

Differential Revision: D35420569

Pulled By: Chillee

fbshipit-source-id: e25a26b85f5056ba7b5b73448b03aa9926ce00df
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Oct 29, 2022
@Chillee @pytorchmergebot
Reland NVFuser guard changes
2614702 
Reland of pytorch/pytorch#75016 with `USE_CUDA` => `USE_NVFUSER`
Pull Request resolved: pytorch/pytorch#75303
Approved by: https://github.com/jjsjann123, https://github.com/davidberard98
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Nov 10, 2022
@Chillee @pytorchmergebot
Reland NVFuser guard changes
13c7524 
Reland of pytorch/pytorch#75016 with `USE_CUDA` => `USE_NVFUSER`
Pull Request resolved: pytorch/pytorch#75303
Approved by: https://github.com/jjsjann123, https://github.com/davidberard98
@github-actions github-actions Bot deleted the nvfuser_guard branch February 15, 2024 01:57
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@Chillee @pytorchmergebot
Reland NVFuser guard changes
bac1f16 
Reland of pytorch#75016 with `USE_CUDA` => `USE_NVFUSER`
Pull Request resolved: pytorch#75303
Approved by: https://github.com/jjsjann123, https://github.com/davidberard98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjsjann123 jjsjann123 jjsjann123 approved these changes

+1 more reviewer

@davidberard98 davidberard98 davidberard98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Chillee @facebook-github-bot @jjsjann123 @davidberard98