Skip to content

Add "pytorch/metamates" to merge_rules.json#75226

Closed
bigfootjon wants to merge 3 commits intomasterfrom
meta-employees-superusers
Closed

Add "pytorch/metamates" to merge_rules.json#75226
bigfootjon wants to merge 3 commits intomasterfrom
meta-employees-superusers

Conversation

@bigfootjon
Copy link
Member

@bigfootjon bigfootjon commented Apr 4, 2022

This will allow us to enable co-development merges between phabricator and GitHub

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 4, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 9cb5be4 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

malfet
malfet requested changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the rest of the folks from the list (as they already should be the members of that group)

@bigfootjon
Cleanup
4d75bf7 
1. remove redundant entries
2. rename the team
@bigfootjon bigfootjon changed the title Add "pytorch/facebook" to merge_rules.json Add "pytorch/metamates" to merge_rules.json Apr 4, 2022
@bigfootjon bigfootjon requested a review from malfet April 4, 2022 21:39
@malfet
Copy link
Contributor

malfet commented Apr 4, 2022

@pytorchbot merge this

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 4, 2022

Merge failed due to Refusing to merge as mandatory check Lint failed for rule OSS CI
Raised by https://github.com/pytorch/pytorch/actions/runs/2092679287

@bigfootjon
Copy link
Member Author

bigfootjon commented Apr 4, 2022

@pytorchbot merge this

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 4, 2022

Merge failed due to Refusing to merge as mandatory check Lint failed for rule OSS CI
Raised by https://github.com/pytorch/pytorch/actions/runs/2092691548

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 4, 2022

@bigfootjon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

seemethere
seemethere approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

facebook-github-bot pushed a commit that referenced this pull request Apr 4, 2022
@bigfootjon @facebook-github-bot
Add "pytorch/metamates" to merge_rules.json (#82)
957c313 
Summary:
X-link: pytorch/pytorch-canary#82

This will allow us to enable co-development merges between phabricator and GitHub

Pull Request resolved: #75226

Reviewed By: malfet, seemethere

Differential Revision: D35375458

Pulled By: bigfootjon

fbshipit-source-id: e25f35e02b404850132c3972744202d27a18d8aa
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Hey @bigfootjon.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@github-actions github-actions bot deleted the meta-employees-superusers branch February 15, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@malfet malfet malfet approved these changes

@janeyx99 janeyx99 Awaiting requested review from janeyx99

@atalman atalman Awaiting requested review from atalman

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bigfootjon @facebook-github-bot @malfet @pytorchmergebot @seemethere