Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit cb79ff3 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@pytorchmergebot merge this |
|
Merge failed due to PR 74793 does not match merge rules |
|
@pytorchmergebot merge this |
|
Hey @linbinyu. |
|
@pytorchbot revert this, broke internal formatters |
This reverts commit 91ef3c8. Reverted #74793 on behalf of https://github.com/seemethere
See #74793 for more details Redo everything in one pr. This diff added test model generation script and updated android and ios tests. Pull Request resolved: #74947 Approved by: https://github.com/kit1980
Summary: See #74793 for more details Redo everything in one pr. This diff added test model generation script and updated android and ios tests. Pull Request resolved: #74947 Approved by: https://github.com/kit1980 allow-large-files Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/28a4b4759add0b3eb0f4c34a1e042be4f93e976e Reviewed By: atalman Differential Revision: D35284140 Pulled By: linbinyu fbshipit-source-id: 50c73e006554b8e4301275599433b69950ff9e33
This pr moved some model generation scripts to a central place (mobile net v2, android test model) updated scripts so these models can run on Android (Java doesn't support certain scalar types as return value) updated model generation script to take arguments (generate models for android/ios, checked-in model or on-the-fly model) add Android instrumentation tests for these new models After this change, the Android instrumentation test will run 35 models which covered 91% of production ops. The coverage information can be found in this file: https://github.com/pytorch/pytorch/blob/master/test/mobile/model_test/coverage.yaml Note that these models are checked-in for back compatibility check (to ensure they can run with newer pytorch versions). The script generates models for mobile test. For each model we have a "checked-in" version and an "on-the-fly" version. The "on-the-fly" version will be generated during test, and should not be committed to the repo. The "checked-in" version is used for back compatibility check. Note that Android only support checked-in model right now. iOS can test both (in another pr). use 'gen_test_model.py android-test' to generate on the fly models for android use 'gen_test_model.py ios-test' to generate on the fly models for ios use 'python gen_test_model.py android' to generate checked-in models for android use 'python gen_test_model.py ios' to generate on-the-fly models for ios use 'gen_test_model.py <model_name_no_suffix>' to update the given checked-in model Pull Request resolved: pytorch#74793 Approved by: https://github.com/kit1980
This reverts commit 016d17b. Reverted pytorch#74793 on behalf of https://github.com/seemethere
See pytorch#74793 for more details Redo everything in one pr. This diff added test model generation script and updated android and ios tests. Pull Request resolved: pytorch#74947 Approved by: https://github.com/kit1980
This pr
moved some model generation scripts to a central place (mobile net v2, android test model)
updated scripts so these models can run on Android (Java doesn't support certain scalar types as return value)
updated model generation script to take arguments (generate models for android/ios, checked-in model or on-the-fly model)
add Android instrumentation tests for these new models
After this change, the Android instrumentation test will run 35 models which covered 91% of production ops. The coverage information can be found in this file: https://github.com/pytorch/pytorch/blob/master/test/mobile/model_test/coverage.yaml
Note that these models are checked-in for back compatibility check (to ensure they can run with newer pytorch versions).
The script generates models for mobile test. For each model we have a "checked-in" version
and an "on-the-fly" version. The "on-the-fly" version will be generated during test, and
should not be committed to the repo. The "checked-in" version is used for back compatibility check.
Note that Android only support checked-in model right now. iOS can test both (in another pr).
use 'gen_test_model.py android-test' to generate on the fly models for android
use 'gen_test_model.py ios-test' to generate on the fly models for ios
use 'python gen_test_model.py android' to generate checked-in models for android
use 'python gen_test_model.py ios' to generate on-the-fly models for ios
use 'gen_test_model.py <model_name_no_suffix>' to update the given checked-in model