kernel_size as the default stride for avg_pool1d#744
Merged
soumith merged 1 commit intopytorch:masterfrom Feb 15, 2017
Merged
Conversation
Following the documentation, let stride to be kernel_size if stride is not provided.
apaszke
reviewed
Feb 15, 2017
Contributor
apaszke
left a comment
There was a problem hiding this comment.
You have to add that (1,) tuple to both values. Wrap the if in parenthesis and add it later.
Collaborator
|
@apaszke it's added to kernel_size above, so it doesn't need to be added again to stride on the else condition |
Collaborator
|
thanks @supakjk |
soumith
pushed a commit
to killeent/pytorch
that referenced
this pull request
Apr 28, 2017
* move TopK to generic * partial genericization of kernel code * introduce TopKTypeConfig, specialize radix type and conversion for floats * implement topk for byte tensor * implement for char tensor * implement for int tensor, extend test to check indices as well * works for longs too * make bitfield set/get a struct, add support for 64-bit types * extend to double tensor * implement for half tensor * asserts; test fix
onnxbot
added a commit
that referenced
this pull request
Apr 10, 2018
ashishfarmer
pushed a commit
to ashishfarmer/pytorch
that referenced
this pull request
Oct 6, 2020
switch to atomicAdd for half datatype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the documentation, let stride to be kernel_size if stride is not provided.