Closed
Conversation
Contributor
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit a89ea49 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Contributor
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
d622947 to
a3636ef
Compare
Contributor
Author
|
Tested 'python setup.py install' on Win10 (x86/arm64) and I got linker out of memory error. |
Contributor
Author
|
Test results:
|
a3636ef to
caea8c4
Compare
Contributor
Author
|
Build configuration |
This patch enables Pytorch build from source with Ninja and 'Visual Studio 16 2019' CMake generator on Windows on Arm. Tests: - Build from source: 'python setup.py develop'. - Run simple Pytorch example: passed - python test\test_torch.py: -- same results as on x64 -- Ran 1344 tests, failures=2
caea8c4 to
a89ea49
Compare
everton1984
reviewed
Feb 15, 2022
| // Windows always little endian | ||
| #define __BYTE_ORDER __LITTLE_ENDIAN | ||
|
|
||
| #if !defined(_M_ARM64) |
Contributor
There was a problem hiding this comment.
@gaborkertesz-linaro Here you guard against using Intel intrinsics on Windows on Arm, MSVC has no specific Arm intrinsics to handle prefetching?
Contributor
Author
There was a problem hiding this comment.
According to Microsoft documentation, it's an MSVC definition for ARM64:
https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170#microsoft-specific-predefined-macros
Defined as 1 for compilations that target 64-bit ARM processors. Otherwise, undefined.
Here we need the __BYTE_ORDER definition for MSVC, but for ARM64 we shouldn't include the Intel specific xmmintrin.h.
I think this change is the least intrusive and has been tested with MSVC.
Do you have any other better proposal?
Contributor
Author
|
@malfet @jbschlosser @albanD Could you review this PR or help me to get a reviewer and start a discussion? |
Collaborator
|
@malfet should be the right person to take a look at this. |
Contributor
Author
|
@malfet Polite ping, could you take a review, thanks! |
malfet
approved these changes
Feb 28, 2022
Contributor
|
There are no way of testing those, so it will likely to regression, but changes themselves looks good to me. |
Contributor
|
@pytorchbot merge this please |
Contributor
|
Hey @gaborkertesz-linaro. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
Summary: This patch enables Pytorch build from source with Ninja and 'Visual Studio 16 2019' CMake generator on Windows on Arm. Pull Request resolved: #72424 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/c4ff49f4c7 - Build from source: 'python setup.py develop'. - Run simple Pytorch example: passed - python test\test_torch.py: -- same results as on x64 -- Ran 1344 tests, failures=2 Reviewed By: malfet Differential Revision: D34527927 Pulled By: malfet fbshipit-source-id: 4e15a912625326d34b19d91572b7c3d2a434483a
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 3, 2022
This patch enables Pytorch build from source with Ninja and 'Visual Studio 16 2019' CMake generator on Windows on Arm. Tests: - Build from source: 'python setup.py develop'. - Run simple Pytorch example: passed - python test\test_torch.py: -- same results as on x64 -- Ran 1344 tests, failures=2 Pull Request resolved: pytorch/pytorch#72424
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 3, 2022
This patch enables Pytorch build from source with Ninja and 'Visual Studio 16 2019' CMake generator on Windows on Arm. Tests: - Build from source: 'python setup.py develop'. - Run simple Pytorch example: passed - python test\test_torch.py: -- same results as on x64 -- Ran 1344 tests, failures=2 Pull Request resolved: pytorch/pytorch#72424
Contributor
|
@malfet Sorry to ask but any reason why this PR was closed? Is something missing? |
Collaborator
|
The way our merging is done is not via github's UI. The bot is merging the change in master and closes the PR. So this is merged in master. |
Contributor
|
@albanD Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enables Pytorch build from source with Ninja and
'Visual Studio 16 2019' CMake generator on Windows on Arm.
Tests:
-- same results as on x64
-- Ran 1344 tests, failures=2