Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit a914e99 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
vfdev-5
reviewed
Feb 2, 2022
zou3519
approved these changes
Feb 2, 2022
Contributor
zou3519
left a comment
There was a problem hiding this comment.
LGTM. I ran the functorch tests locally to confirm and saw the same thing as you did, @lezcano. Since that test (test_vmapjvpall_norm_nuc_cpu_float32) is not a regression, we don't need to worry about fixing it soon.
Once we have actual Composite Compliance testing for backward passes, we'll be able to add a lot of in-place operations back into the backward pass and have confidence that it won't break functorch :)
Contributor
|
@zou3519 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
Summary: This should (hopefully) make all the CI from `functorch` go green (including jvp's!) after changing `VARIADIC_BDIMS_BOXED(_svd_helper);` with `VARIADIC_BDIMS_BOXED(_linalg_svd);` and removing all the skip and xfails associated to `linalg.svdvals`. Locally, there's just one test that started failing because of this, and that is `test_vmapjvpall_norm_nuc_cpu_float32`. I have no idea what's going on here, but it's a jvp product, so not a regression, and it might very well be caused by the jvp of other operation within `norm_nuc` as this is a composite operation. Pull Request resolved: #72181 Reviewed By: ngimel Differential Revision: D33952744 Pulled By: zou3519 fbshipit-source-id: 2a2510d97eed4a0bfc25615264ddd36e38856efe
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 3, 2022
Summary: This should (hopefully) make all the CI from `functorch` go green (including jvp's!) after changing `VARIADIC_BDIMS_BOXED(_svd_helper);` with `VARIADIC_BDIMS_BOXED(_linalg_svd);` and removing all the skip and xfails associated to `linalg.svdvals`. Locally, there's just one test that started failing because of this, and that is `test_vmapjvpall_norm_nuc_cpu_float32`. I have no idea what's going on here, but it's a jvp product, so not a regression, and it might very well be caused by the jvp of other operation within `norm_nuc` as this is a composite operation. Pull Request resolved: #72181 Reviewed By: ngimel Differential Revision: D33952744 Pulled By: zou3519 fbshipit-source-id: 2a2510d97eed4a0bfc25615264ddd36e38856efe (cherry picked from commit 5805fa1)
Contributor
|
Hey Lezcano. |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: This should (hopefully) make all the CI from `functorch` go green (including jvp's!) after changing `VARIADIC_BDIMS_BOXED(_svd_helper);` with `VARIADIC_BDIMS_BOXED(_linalg_svd);` and removing all the skip and xfails associated to `linalg.svdvals`. Locally, there's just one test that started failing because of this, and that is `test_vmapjvpall_norm_nuc_cpu_float32`. I have no idea what's going on here, but it's a jvp product, so not a regression, and it might very well be caused by the jvp of other operation within `norm_nuc` as this is a composite operation. Pull Request resolved: pytorch/pytorch#72181 Reviewed By: ngimel Differential Revision: D33952744 Pulled By: zou3519 fbshipit-source-id: 2a2510d97eed4a0bfc25615264ddd36e38856efe (cherry picked from commit 5805fa107c3a91c58f8ecc9778cfc87aa7f64233)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: This should (hopefully) make all the CI from `functorch` go green (including jvp's!) after changing `VARIADIC_BDIMS_BOXED(_svd_helper);` with `VARIADIC_BDIMS_BOXED(_linalg_svd);` and removing all the skip and xfails associated to `linalg.svdvals`. Locally, there's just one test that started failing because of this, and that is `test_vmapjvpall_norm_nuc_cpu_float32`. I have no idea what's going on here, but it's a jvp product, so not a regression, and it might very well be caused by the jvp of other operation within `norm_nuc` as this is a composite operation. Pull Request resolved: pytorch/pytorch#72181 Reviewed By: ngimel Differential Revision: D33952744 Pulled By: zou3519 fbshipit-source-id: 2a2510d97eed4a0bfc25615264ddd36e38856efe (cherry picked from commit 5805fa107c3a91c58f8ecc9778cfc87aa7f64233)
zou3519
pushed a commit
that referenced
this pull request
Feb 3, 2022
Summary: This should (hopefully) make all the CI from `functorch` go green (including jvp's!) after changing `VARIADIC_BDIMS_BOXED(_svd_helper);` with `VARIADIC_BDIMS_BOXED(_linalg_svd);` and removing all the skip and xfails associated to `linalg.svdvals`. Locally, there's just one test that started failing because of this, and that is `test_vmapjvpall_norm_nuc_cpu_float32`. I have no idea what's going on here, but it's a jvp product, so not a regression, and it might very well be caused by the jvp of other operation within `norm_nuc` as this is a composite operation. Pull Request resolved: #72181 Reviewed By: ngimel Differential Revision: D33952744 Pulled By: zou3519 fbshipit-source-id: 2a2510d97eed4a0bfc25615264ddd36e38856efe (cherry picked from commit 5805fa1)
atalman
added a commit
that referenced
this pull request
Feb 4, 2022
* release 1.11 Install torch from test channel, Pin builder and xla repo (#72217) * Make svd / svdvals fully functorch compatible (#72181) Summary: This should (hopefully) make all the CI from `functorch` go green (including jvp's!) after changing `VARIADIC_BDIMS_BOXED(_svd_helper);` with `VARIADIC_BDIMS_BOXED(_linalg_svd);` and removing all the skip and xfails associated to `linalg.svdvals`. Locally, there's just one test that started failing because of this, and that is `test_vmapjvpall_norm_nuc_cpu_float32`. I have no idea what's going on here, but it's a jvp product, so not a regression, and it might very well be caused by the jvp of other operation within `norm_nuc` as this is a composite operation. Pull Request resolved: #72181 Reviewed By: ngimel Differential Revision: D33952744 Pulled By: zou3519 fbshipit-source-id: 2a2510d97eed4a0bfc25615264ddd36e38856efe (cherry picked from commit 5805fa1) Co-authored-by: Andrey Talman <atalman@fb.com> Co-authored-by: lezcano <lezcano-93@hotmail.com>
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: This should (hopefully) make all the CI from `functorch` go green (including jvp's!) after changing `VARIADIC_BDIMS_BOXED(_svd_helper);` with `VARIADIC_BDIMS_BOXED(_linalg_svd);` and removing all the skip and xfails associated to `linalg.svdvals`. Locally, there's just one test that started failing because of this, and that is `test_vmapjvpall_norm_nuc_cpu_float32`. I have no idea what's going on here, but it's a jvp product, so not a regression, and it might very well be caused by the jvp of other operation within `norm_nuc` as this is a composite operation. Pull Request resolved: pytorch/pytorch#72181 Reviewed By: ngimel Differential Revision: D33952744 Pulled By: zou3519 fbshipit-source-id: 2a2510d97eed4a0bfc25615264ddd36e38856efe (cherry picked from commit 5805fa107c3a91c58f8ecc9778cfc87aa7f64233)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: This should (hopefully) make all the CI from `functorch` go green (including jvp's!) after changing `VARIADIC_BDIMS_BOXED(_svd_helper);` with `VARIADIC_BDIMS_BOXED(_linalg_svd);` and removing all the skip and xfails associated to `linalg.svdvals`. Locally, there's just one test that started failing because of this, and that is `test_vmapjvpall_norm_nuc_cpu_float32`. I have no idea what's going on here, but it's a jvp product, so not a regression, and it might very well be caused by the jvp of other operation within `norm_nuc` as this is a composite operation. Pull Request resolved: pytorch/pytorch#72181 Reviewed By: ngimel Differential Revision: D33952744 Pulled By: zou3519 fbshipit-source-id: 2a2510d97eed4a0bfc25615264ddd36e38856efe (cherry picked from commit 5805fa107c3a91c58f8ecc9778cfc87aa7f64233)
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: This should (hopefully) make all the CI from `functorch` go green (including jvp's!) after changing `VARIADIC_BDIMS_BOXED(_svd_helper);` with `VARIADIC_BDIMS_BOXED(_linalg_svd);` and removing all the skip and xfails associated to `linalg.svdvals`. Locally, there's just one test that started failing because of this, and that is `test_vmapjvpall_norm_nuc_cpu_float32`. I have no idea what's going on here, but it's a jvp product, so not a regression, and it might very well be caused by the jvp of other operation within `norm_nuc` as this is a composite operation. Pull Request resolved: pytorch#72181 Reviewed By: ngimel Differential Revision: D33952744 Pulled By: zou3519 fbshipit-source-id: 2a2510d97eed4a0bfc25615264ddd36e38856efe (cherry picked from commit 5805fa1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should (hopefully) make all the CI from
functorchgo green (including jvp's!) after changingVARIADIC_BDIMS_BOXED(_svd_helper);withVARIADIC_BDIMS_BOXED(_linalg_svd);and removing all the skip and xfails associated tolinalg.svdvals.Locally, there's just one test that started failing because of this, and that is
test_vmapjvpall_norm_nuc_cpu_float32. I have no idea what's going on here, but it's a jvp product, so not a regression, and it might very well be caused by the jvp of other operation withinnorm_nucas this is a composite operation.