Removed JIT FC tweaks for interpolation options by vfdev-5 · Pull Request #71937 · pytorch/pytorch

vfdev-5 · 2022-01-27T21:02:40Z

Description:

Removed JIT FC tweaks for interpolation options : nearest-exact and antialiasing

They were added in

Added nearest-exact interpolation mode #64501 (Sept 04 2021)
Added antialias flag to interpolate (CPU only, bilinear) #65142 (Sept 16 2021)

cc @jbschlosser

pytorch-bot · 2022-01-27T21:02:44Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/5162bee8516c545ed4e1bfe0c93f4c509fcc7568/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`, `ciflow/xla`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
windows-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-bionic-rocm4.5-py3.7	`ciflow/linux`, `ciflow/rocm`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped

facebook-github-bot · 2022-01-27T21:02:46Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/71937
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 5162bee (more details on the Dr. CI page):

1/2 failures introduced in this PR
1/2 broken upstream at merge base eeda31f on Jan 27 from 10:54am to 7:16pm

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

linux-bionic-py3.7-clang9 / test (default, 1, 2, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-01-27T22:09:11.8959780Z RuntimeError: test_multiprocessing_spawn failed!

2022-01-27T22:09:11.7367830Z 
2022-01-27T22:09:11.7367990Z Generating XML reports...
2022-01-27T22:09:11.7398101Z Generated XML report: test-reports/python-unittest/test_multiprocessing_spawn/TEST-ErrorTest-20220127220901.xml
2022-01-27T22:09:11.7406440Z Generated XML report: test-reports/python-unittest/test_multiprocessing_spawn/TEST-ForkTest-20220127220901.xml
2022-01-27T22:09:11.7422130Z Generated XML report: test-reports/python-unittest/test_multiprocessing_spawn/TEST-SpawnTest-20220127220901.xml
2022-01-27T22:09:11.8954966Z Traceback (most recent call last):
2022-01-27T22:09:11.8955264Z   File "test/run_test.py", line 1101, in <module>
2022-01-27T22:09:11.8957325Z     main()
2022-01-27T22:09:11.8957562Z   File "test/run_test.py", line 1079, in main
2022-01-27T22:09:11.8959463Z     raise RuntimeError(err_message)
2022-01-27T22:09:11.8959780Z RuntimeError: test_multiprocessing_spawn failed!
2022-01-27T22:09:12.0976581Z 
2022-01-27T22:09:12.0976988Z real	28m6.870s
2022-01-27T22:09:12.0977169Z user	58m33.673s
2022-01-27T22:09:12.0977354Z sys	2m43.563s
2022-01-27T22:09:12.0977577Z + cleanup
2022-01-27T22:09:12.0977819Z + retcode=1
2022-01-27T22:09:12.0978035Z + set +x
2022-01-27T22:09:12.1018467Z ##[error]Process completed with exit code 1.
2022-01-27T22:09:12.1067834Z ##[group]Run # Ensure the working directory gets chowned back to the current user
2022-01-27T22:09:12.1068211Z �[36;1m# Ensure the working directory gets chowned back to the current user�[0m

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

linux-bionic-py3.7-clang9 / test (xla, 1, 1, linux.2xlarge) on Jan 27 from 10:54am to 7:16pm (e020414 - 7bc5962)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

jbschlosser

Beautiful :) LGTM!

facebook-github-bot · 2022-01-28T15:28:20Z

@jbschlosser has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: Description: - Removed JIT FC tweaks for interpolation options : nearest-exact and antialiasing They were added in - #64501 (Sept 04 2021) - #65142 (Sept 16 2021) cc jbschlosser Pull Request resolved: #71937 Reviewed By: mrshenli Differential Revision: D33845502 Pulled By: jbschlosser fbshipit-source-id: 8a94454fd643cd2aef21b06689f72a0f16620d30

Summary: Description: - Removed JIT FC tweaks for interpolation options : nearest-exact and antialiasing They were added in - pytorch/pytorch#64501 (Sept 04 2021) - pytorch/pytorch#65142 (Sept 16 2021) cc jbschlosser Pull Request resolved: pytorch/pytorch#71937 Reviewed By: mrshenli Differential Revision: D33845502 Pulled By: jbschlosser fbshipit-source-id: 8a94454fd643cd2aef21b06689f72a0f16620d30 (cherry picked from commit b21173d)

Removed JIT FC tweaks for interpolation options

5162bee

vfdev-5 requested review from albanD and jbschlosser as code owners January 27, 2022 21:02

pytorch-bot bot added the ciflow/default label Jan 27, 2022

facebook-github-bot added the cla signed label Jan 27, 2022

pytorchbot added the open source label Jan 27, 2022

albanD removed their request for review January 28, 2022 15:26

jbschlosser approved these changes Jan 28, 2022

View reviewed changes

pytorchmergebot closed this in 63429bf Jan 28, 2022

vfdev-5 deleted the enable-jit-interp-options branch January 28, 2022 19:59

vfdev-5 mentioned this pull request Feb 1, 2022

Remove custom ops interpolation with antialiasing pytorch/vision#5329

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed JIT FC tweaks for interpolation options#71937

Removed JIT FC tweaks for interpolation options#71937
vfdev-5 wants to merge 1 commit intomasterfrom
enable-jit-interp-options

vfdev-5 commented Jan 27, 2022 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jan 27, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Jan 27, 2022 •

edited

Loading

Uh oh!

jbschlosser left a comment

Uh oh!

facebook-github-bot commented Jan 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vfdev-5 commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jan 27, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

linux-bionic-py3.7-clang9 / test (default, 1, 2, linux.2xlarge) (1/1)

🚧 1 fixed upstream failure:

Uh oh!

jbschlosser left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jan 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vfdev-5 commented Jan 27, 2022 •

edited

Loading

facebook-github-bot commented Jan 27, 2022 •

edited

Loading