Remove deprecated torch.solve#70986
Closed
IvanYashchuk wants to merge 16 commits intopytorch:masterfrom
Closed
Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
❌ 1 New FailuresAs of commit 155b7f5 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
3 tasks
lezcano
reviewed
Jan 19, 2022
Collaborator
lezcano
left a comment
There was a problem hiding this comment.
I won't cry when this one's gone either. Now, I left a few comments regarding the MAGMA / LAPACK functions that we're removing.
| } | ||
|
|
||
| template<> void lapackSolve<float>(int n, int nrhs, float *a, int lda, int *ipiv, float *b, int ldb, int *info) { | ||
| sgesv_(&n, &nrhs, a, &lda, ipiv, b, &ldb, info); |
Collaborator
There was a problem hiding this comment.
Why don't we want to keep these kernels? Shouldn't they be more efficient than lu + lu_solve?
Collaborator
Author
There was a problem hiding this comment.
No, they are not more efficient. gesv = getrf + getrs but done in an external library. We should leave only the code that is used.
Comment on lines
-166
to
-173
| template<> | ||
| void magmaSolve<double>( | ||
| magma_int_t n, magma_int_t nrhs, double* dA, magma_int_t ldda, | ||
| magma_int_t* ipiv, double* dB, magma_int_t lddb, magma_int_t* info) { | ||
| MagmaStreamSyncGuard guard; | ||
| magma_dgesv_gpu(n, nrhs, dA, ldda, ipiv, dB, lddb, info); | ||
| AT_CUDA_CHECK(cudaGetLastError()); | ||
| } |
albanD
reviewed
May 5, 2022
Collaborator
albanD
left a comment
There was a problem hiding this comment.
Thanks for the PR Ivan.
Do you think it would be possible to add to torch/__init__.py something like:
# This function was depreacted and removed.
# This nice error message can be removed in version 1.3+
def solve(input, A, out=None):
raise RuntimeError("This function was deprecated since version 1.9 and is now removed. Please use the `torch.linalg.solve` function instead")To make sure that users get a nice error message for a couple versions?
Collaborator
Author
|
Sure, I will add that. |
Collaborator
Author
|
Alright, I added a In [1]: import torch
In [2]: a = torch.randn(3, 3)
In [3]: b = torch.randn(3, 3)
In [4]: torch.solve(b, a)
---------------------------------------------------------------------------
RuntimeError Traceback (most recent call last)
<ipython-input-4-6f9b9974b5b1> in <module>
----> 1 torch.solve(b, a)
RuntimeError: This function was deprecated since version 1.9 and is now removed. Please use the `torch.linalg.solve` function instead.
In [5]: b.solve(a)
---------------------------------------------------------------------------
RuntimeError Traceback (most recent call last)
<ipython-input-5-fd669f2275c3> in <module>
----> 1 b.solve(a)
RuntimeError: This function was deprecated since version 1.9 and is now removed. Please use the `torch.linalg.solve` function instead. |
Collaborator
|
If you ever manage to land this, remind me to remove in #74046 the backward functions for |
albanD
reviewed
May 9, 2022
| # triangular_solve goes through specific backend dispatch (CPU/CUDA) and hit auto-generated device check first | ||
| generic_backend_dispatch_err_str = "Expected b and A to be on the same device" | ||
| specific_backend_dispatch_err_str = "Expected all tensors to be on the same device" | ||
| with self.assertRaisesRegex(RuntimeError, generic_backend_dispatch_err_str): |
Collaborator
There was a problem hiding this comment.
nit: could you leave a small test here (or in test_torch.py) that the error you added is working as expected?
Collaborator
Author
|
I added a test checking that the error is raised as expected and resolved accumulated merge conflicts. |
Collaborator
|
@pytorchbot merge this please |
Contributor
|
Hey @IvanYashchuk. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 13, 2022
Summary: The time has come to remove deprecated linear algebra related functions. This PR removes `torch.solve`. cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Pull Request resolved: #70986 Approved by: https://github.com/Lezcano, https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/890bdf13e17adcd0ede255afbf5abf29b7d8d6ee Reviewed By: malfet Differential Revision: D36299674 Pulled By: malfet fbshipit-source-id: fd01095c72787103d16c442595f67f5020f393fb
This was referenced May 20, 2022
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
The time has come to remove deprecated linear algebra related functions. This PR removes `torch.solve`. cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano Pull Request resolved: pytorch#70986 Approved by: https://github.com/Lezcano, https://github.com/albanD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The time has come to remove deprecated linear algebra related functions. This PR removes
torch.solve.cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano