Skip to content

Remove deprecated torch.eig#70982

Closed
IvanYashchuk wants to merge 26 commits intopytorch:masterfrom
IvanYashchuk:remove-eig
Closed

Remove deprecated torch.eig#70982
IvanYashchuk wants to merge 26 commits intopytorch:masterfrom
IvanYashchuk:remove-eig

Conversation

@IvanYashchuk
Copy link
Copy Markdown
Collaborator

@IvanYashchuk IvanYashchuk commented Jan 7, 2022 •
edited by pytorch-probot Bot
Loading

The time has come to remove deprecated linear algebra related functions. This PR removes torch.eig.

cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano

@IvanYashchuk IvanYashchuk added module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul module: deprecation labels Jan 7, 2022
@pytorch-probot
Copy link
Copy Markdown

pytorch-probot Bot commented Jan 7, 2022 •
edited
Loading

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/IvanYashchuk/pytorch/blob/408912394b4a47960d355a0b012ca2da46893725/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/cuda,ciflow/all

Workflows Labels (bold enabled) Status
Triggered Workflows
caffe2-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk ✅ triggered
docker-builds ciflow/all, ciflow/trunk ✅ triggered
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-arm64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-x86-64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
libtorch-linux-xenial-cuda10.2-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk ✅ triggered
libtorch-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk ✅ triggered
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow, ciflow/trunk ✅ triggered
linux-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/trunk ✅ triggered
linux-docs ciflow/all, ciflow/cpu, ciflow/default, ciflow/docs, ciflow/linux, ciflow/trunk ✅ triggered
linux-docs-push ciflow/all, ciflow/cpu, ciflow/linux, ciflow/scheduled ✅ triggered
linux-vulkan-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-no-ops ciflow/all, ciflow/cuda, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7-no-ops ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
macos-10-15-py3-arm64 ciflow/all, ciflow/macos, ciflow/trunk ✅ triggered
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos, ciflow/trunk ✅ triggered
macos-11-py3-x86-64 ciflow/all, ciflow/macos, ciflow/trunk ✅ triggered
parallelnative-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk ✅ triggered
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled ✅ triggered
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled ✅ triggered
periodic-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled ✅ triggered
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck ✅ triggered
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled ✅ triggered
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win ✅ triggered
periodic-win-vs2019-cuda11.5-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build ciflow/all, ciflow/android, ciflow/cpu, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
Skipped Workflows

You can add a comment to the PR and tag @pytorchbot with the following commands: 
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 7, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit b26952f (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@IvanYashchuk IvanYashchuk mentioned this pull request Jan 7, 2022
Closed
3 tasks
@dagitses dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 10, 2022
@pytorch-probot pytorch-probot Bot assigned pytorchbot and unassigned pytorchbot Jan 11, 2022
@IvanYashchuk IvanYashchuk mentioned this pull request Jan 13, 2022
Closed
lezcano
lezcano approved these changes Jan 19, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this one gone!

malfet
malfet approved these changes Aug 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase, but LGTM provided that CI is green

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 4, 2022

@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kit1980
Copy link
Copy Markdown
Contributor

kit1980 commented Sep 4, 2022

Please do not merge until I confirm the internal tests pass.

@IvanYashchuk
Copy link
Copy Markdown
Collaborator Author

IvanYashchuk commented Sep 7, 2022 •
edited
Loading

How do internal tests look, did they pass?

@kit1980
Copy link
Copy Markdown
Contributor

kit1980 commented Sep 7, 2022

How do internal tests look, did they pass?

Removing one old piece of code that fails currently.

@kit1980
Copy link
Copy Markdown
Contributor

kit1980 commented Sep 9, 2022

@IvanYashchuk I'm going to land the diff internally soon, the PR will be merged automatically after that.

facebook-github-bot pushed a commit to pytorch/functorch that referenced this pull request Sep 9, 2022
@IvanYashchuk @facebook-github-bot
Remove deprecated torch.eig (#70982)
b7f3908 
Summary:
The time has come to remove deprecated linear algebra related functions. This PR removes `torch.eig`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

X-link: pytorch/pytorch#70982

Reviewed By: malfet

Differential Revision: D37966198

Pulled By: kit1980

fbshipit-source-id: 83eccb849480dd022f3c7597755089656187220f
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 9, 2022

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 9, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 9, 2022

Hey @IvanYashchuk.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@kit1980
Copy link
Copy Markdown
Contributor

kit1980 commented Sep 9, 2022

Landed!
Hopefully there will be no unforeseen issues...

facebook-github-bot pushed a commit that referenced this pull request Sep 9, 2022
@IvanYashchuk @facebook-github-bot
Remove deprecated torch.eig (#70982)
01e3fb0 
Summary:
The time has come to remove deprecated linear algebra related functions. This PR removes `torch.eig`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Pull Request resolved: #70982

Reviewed By: malfet

Differential Revision: D37966198

Pulled By: kit1980

fbshipit-source-id: 83eccb849480dd022f3c7597755089656187220f
@kit1980
Copy link
Copy Markdown
Contributor

kit1980 commented Sep 9, 2022

OK, functorch test is failing https://github.com/pytorch/pytorch/runs/8279538230?check_suite_focus=true
I'm trying to forward-fix

kit1980 added a commit that referenced this pull request Sep 9, 2022
@kit1980
Remove last bit or torch.eig from functorch/test/test_ops.py
5d1280d 
After #70982
@kit1980 kit1980 mentioned this pull request Sep 9, 2022
Closed
pytorchmergebot pushed a commit that referenced this pull request Sep 9, 2022
@kit1980 @pytorchmergebot
Remove last bit or torch.eig from functorch/test/test_ops.py (#84787)
f598b5b 
After #70982

Pull Request resolved: #84787
Approved by: https://github.com/suo, https://github.com/seemethere
facebook-github-bot pushed a commit to pytorch/functorch that referenced this pull request Sep 11, 2022
@kit1980 @facebook-github-bot
Remove last bit or torch.eig from functorch/test/test_ops.py (#84787)…
d9375c2 
… (#84787)

Summary:
After pytorch/pytorch#70982

X-link: pytorch/pytorch#84787
Approved by: https://github.com/suo, https://github.com/seemethere

Reviewed By: izaitsevfb

Differential Revision: D39407114

Pulled By: kit1980

fbshipit-source-id: b545cd52dd442930b2a07f7acdf4973d23cc22a1
facebook-github-bot pushed a commit that referenced this pull request Sep 11, 2022
@kit1980 @facebook-github-bot
Remove last bit or torch.eig from functorch/test/test_ops.py (#84787) (…
adee1a6 
…#84787)

Summary:
After #70982

Pull Request resolved: #84787
Approved by: https://github.com/suo, https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f598b5be1825fc0a12b5013c547fb5972b57b208

Reviewed By: izaitsevfb

Differential Revision: D39407114

Pulled By: kit1980

fbshipit-source-id: b545cd52dd442930b2a07f7acdf4973d23cc22a1
mrshenli added a commit to mrshenli/tau that referenced this pull request Sep 13, 2022
@mrshenli
Remove deprecated eig
41067da 
`eig` is removed from PyTorch by
pytorch/pytorch#70982. Update spmd accordingly.
@mrshenli mrshenli mentioned this pull request Sep 13, 2022
Merged
mrshenli added a commit to pytorch/PiPPy that referenced this pull request Sep 13, 2022
@mrshenli
Remove deprecated eig (#454)
d2175f3 
`eig` is removed from PyTorch by
pytorch/pytorch#70982. Update spmd accordingly.
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@IvanYashchuk @pytorchmergebot
Remove deprecated torch.eig (pytorch#70982)
5b5e6b8 
The time has come to remove deprecated linear algebra related functions. This PR removes `torch.eig`.

cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano
Pull Request resolved: pytorch#70982
Approved by: https://github.com/Lezcano, https://github.com/malfet
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@kit1980 @pytorchmergebot
Remove last bit or torch.eig from functorch/test/test_ops.py (pytorch…
752f636 
…#84787)

After pytorch#70982

Pull Request resolved: pytorch#84787
Approved by: https://github.com/suo, https://github.com/seemethere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@lezcano lezcano lezcano approved these changes

@mruberry mruberry Awaiting requested review from mruberry

Assignees

@mruberry mruberry

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged module: deprecation module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@IvanYashchuk @facebook-github-bot @mruberry @kit1980 @lezcano @pytorchmergebot @malfet @ezyang @dagitses @pytorchbot