[Array API] Add linalg.diagonal#70599
Closed
lezcano wants to merge 2 commits intogh/Lezcano/47/basefrom
Closed
Conversation
This PR adds `linalg.diagonal` following the Array API: https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html#linalg-diagonal-x-axis1-0-axis2-1-offset-0 Fixes #62813 [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit d477620 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
lezcano
added a commit
that referenced
this pull request
Jan 4, 2022
This PR adds `linalg.diagonal` following the Array API: https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html#linalg-diagonal-x-axis1-0-axis2-1-offset-0 Fixes #62813 ghstack-source-id: d6d71a2 Pull Request resolved: #70599
28 tasks
mruberry
reviewed
Jan 25, 2022
| supports_fwgrad_bwgrad=True, | ||
| sample_inputs_func=sample_inputs_diagonal_diag_embed), | ||
| OpInfo('diagonal', | ||
| # They are not strictly aliases, but we can see them as aliases for testing purposes |
Collaborator
There was a problem hiding this comment.
How are they not "strictly" aliases?
Collaborator
Author
There was a problem hiding this comment.
Becuase this one has -2, -1 as the default dims (good) while torch.diagonal has 0, 1 as default dims (ugh).
Collaborator
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Collaborator
|
@lezcano Internal systems can't rebase this manually - it just needs a rebase and then please ping me to merge it. |
This PR adds `linalg.diagonal` following the Array API: https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html#linalg-diagonal-x-axis1-0-axis2-1-offset-0 Fixes #62813 cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano rgommers pmeier asmeurer leofang AnirudhDagar asi1024 emcastillo kmaehashi Differential Revision: [D33760506](https://our.internmc.facebook.com/intern/diff/D33760506) [ghstack-poisoned]
lezcano
added a commit
that referenced
this pull request
Jan 25, 2022
This PR adds `linalg.diagonal` following the Array API: https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html#linalg-diagonal-x-axis1-0-axis2-1-offset-0 Fixes #62813 ghstack-source-id: 5368849 Pull Request resolved: #70599
Collaborator
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
Summary: Pull Request resolved: #70599 This PR adds `linalg.diagonal` following the Array API: https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html#linalg-diagonal-x-axis1-0-axis2-1-offset-0 Fixes #62813 cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano rgommers pmeier asmeurer leofang AnirudhDagar asi1024 emcastillo kmaehashi Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D33760506 Pulled By: mruberry fbshipit-source-id: e32c3490321d8c3f31b3bb538bc1f72b39bd2854
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#70599 This PR adds `linalg.diagonal` following the Array API: https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html#linalg-diagonal-x-axis1-0-axis2-1-offset-0 Fixes pytorch/pytorch#62813 cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano rgommers pmeier asmeurer leofang AnirudhDagar asi1024 emcastillo kmaehashi Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D33760506 Pulled By: mruberry fbshipit-source-id: e32c3490321d8c3f31b3bb538bc1f72b39bd2854 (cherry picked from commit 44f41f8)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#70599 This PR adds `linalg.diagonal` following the Array API: https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html#linalg-diagonal-x-axis1-0-axis2-1-offset-0 Fixes pytorch/pytorch#62813 cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano rgommers pmeier asmeurer leofang AnirudhDagar asi1024 emcastillo kmaehashi Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D33760506 Pulled By: mruberry fbshipit-source-id: e32c3490321d8c3f31b3bb538bc1f72b39bd2854 (cherry picked from commit 44f41f8)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#70599 This PR adds `linalg.diagonal` following the Array API: https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html#linalg-diagonal-x-axis1-0-axis2-1-offset-0 Fixes pytorch/pytorch#62813 cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano rgommers pmeier asmeurer leofang AnirudhDagar asi1024 emcastillo kmaehashi Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D33760506 Pulled By: mruberry fbshipit-source-id: e32c3490321d8c3f31b3bb538bc1f72b39bd2854 (cherry picked from commit 44f41f8)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#70599 This PR adds `linalg.diagonal` following the Array API: https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html#linalg-diagonal-x-axis1-0-axis2-1-offset-0 Fixes pytorch/pytorch#62813 cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano rgommers pmeier asmeurer leofang AnirudhDagar asi1024 emcastillo kmaehashi Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D33760506 Pulled By: mruberry fbshipit-source-id: e32c3490321d8c3f31b3bb538bc1f72b39bd2854 (cherry picked from commit 44f41f8)
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: Pull Request resolved: pytorch#70599 This PR adds `linalg.diagonal` following the Array API: https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html#linalg-diagonal-x-axis1-0-axis2-1-offset-0 Fixes pytorch#62813 cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano rgommers pmeier asmeurer leofang AnirudhDagar asi1024 emcastillo kmaehashi Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D33760506 Pulled By: mruberry fbshipit-source-id: e32c3490321d8c3f31b3bb538bc1f72b39bd2854 (cherry picked from commit 44f41f8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR adds
linalg.diagonalfollowing the Array API:https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html#linalg-diagonal-x-axis1-0-axis2-1-offset-0
Fixes #62813
cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano @rgommers @pmeier @asmeurer @leofang @AnirudhDagar @asi1024 @emcastillo @kmaehashi
Differential Revision: D33760506