[C++ API] Added missing nearest-exact mode and anti-alias flag#69318
Closed
vfdev-5 wants to merge 4 commits intopytorch:masterfrom
Closed
[C++ API] Added missing nearest-exact mode and anti-alias flag#69318vfdev-5 wants to merge 4 commits intopytorch:masterfrom
vfdev-5 wants to merge 4 commits intopytorch:masterfrom
Conversation
Description: Following pytorch#65142 (comment) adding missing nearest-exact mode and anti-alias flag - pytorch#65142 - pytorch#64501 cc @cpuhrsch
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e06d4bb (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…te-interp-opts-cppapi
Contributor
|
Adding @jbschlosser as the reviewer since he was also the reviewer for the interpolate PR you reference here. |
jbschlosser
reviewed
Dec 7, 2021
Contributor
jbschlosser
left a comment
There was a problem hiding this comment.
Functional changes look good - please also add tests in test/cpp/api/functional.cpp if you don't mind :)
Contributor
Author
|
@jbschlosser I added the tests and failing test seems unrelated. Could you please review the PR. Thanks |
jbschlosser
approved these changes
Dec 22, 2021
Contributor
jbschlosser
left a comment
There was a problem hiding this comment.
LGTM thanks for the update!
Contributor
|
@jbschlosser has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Is it possible this change forgot to implement the anti-alias path for bicubic implementation? |
Contributor
Author
|
@spiegelball yes, as bicubic op was portes later, probably I forgot about C++ api. Thanks for catching that! |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 13, 2022
…84599) Description: Following #69318 (comment) adding missing bicubic path for anti-alias flag to C++ frontend. - #70930 - added tests in pytorch/test/cpp/api/functional.cpp Pull Request resolved: #84599 Approved by: https://github.com/kit1980, https://github.com/malfet
mehtanirav
pushed a commit
that referenced
this pull request
Oct 4, 2022
…84599) Description: Following #69318 (comment) adding missing bicubic path for anti-alias flag to C++ frontend. - #70930 - added tests in pytorch/test/cpp/api/functional.cpp Pull Request resolved: #84599 Approved by: https://github.com/kit1980, https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Following #65142 (comment) adding missing nearest-exact mode and anti-alias flag to C++ frontend.
Added antialias flag to interpolate (CPU only, bilinear) #65142
Added nearest-exact interpolation mode #64501
added tests in pytorch/test/cpp/api/functional.cpp